chore: Add action to warn about potentially risky PR changes #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kahest
requested review from
adinauer,
markushi,
romtsn and
stefanosiano
as code owners
Contributor
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
kahest
commented
Sep 30, 2024
.github/file-filters.yml
Outdated
| # This is used by the action https://github.com/dorny/paths-filter | ||
|
|
||
| high_risk_code: &high_risk_code | ||
| - ".github/file-filters.yml" |
Contributor
Author
There was a problem hiding this comment.
- this is for testing and will be removed before merging
- need to align on set of potentially higher-risk files before merging as well
- use full repo paths, can check getsentry/sentry-cocoa@main/.github/file-filters.yml for inspiration
romtsn
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Implement a mechanism that automatically adds an "alert" comment to PRs if they include changes to files we think have higher potential to break things than others.
💡 Motivation and Context
same as getsentry/sentry-java#3726
💚 How did you test it?
✅ by adding the file-filter.yml introduced in this PR to the list of potentially risky changes and ensuring that an alert is shown
📝 Checklist
I added tests to verify the changesI updated the docs if neededNo breaking changes🔮 Next steps
#skip-changelog