Skip to content

test: share sdk wrapper xcodegen #5198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 387 commits into from
May 13, 2025

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented May 7, 2025

After linking the shared library to the sample apps in #5181, use the shared SentrySDKWrapper.shared.startSentry() call from all swift apps. leaves iOS-ObjectiveC as-is for now as it's the only one using ObjC to initialize the SDK and we need to ensure all those APIs work in ObjC.

Note: there were some differences between the way the SDK wrapper initializes the SDK by default without overrides, and the way the Camera sample would do it. That is addressed in #5201 and #5202

#skip-changelog

Copy link
Contributor

github-actions bot commented May 7, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.12 ms 1244.24 ms 16.12 ms
Size 23.76 KiB 862.55 KiB 838.79 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
1ee5a37 1209.37 ms 1222.04 ms 12.68 ms
7f691b5 1233.94 ms 1243.80 ms 9.86 ms
e070f8a 1236.47 ms 1250.50 ms 14.03 ms
c8dbe73 1215.37 ms 1237.31 ms 21.94 ms
aeec206 1229.27 ms 1253.70 ms 24.43 ms
c810e58 1221.57 ms 1250.45 ms 28.88 ms
034be1c 1222.67 ms 1236.22 ms 13.55 ms
533859f 1237.78 ms 1249.76 ms 11.98 ms
4977fbc 1231.55 ms 1239.80 ms 8.25 ms
742d4b6 1204.00 ms 1217.90 ms 13.90 ms

App size

Revision Plain With Sentry Diff
1ee5a37 21.58 KiB 670.39 KiB 648.81 KiB
7f691b5 20.76 KiB 420.55 KiB 399.79 KiB
e070f8a 21.58 KiB 546.20 KiB 524.62 KiB
c8dbe73 21.58 KiB 615.91 KiB 594.33 KiB
aeec206 20.76 KiB 434.88 KiB 414.12 KiB
c810e58 22.32 KiB 761.10 KiB 738.78 KiB
034be1c 20.76 KiB 436.66 KiB 415.90 KiB
533859f 22.85 KiB 408.84 KiB 386.00 KiB
4977fbc 20.76 KiB 419.86 KiB 399.10 KiB
742d4b6 21.58 KiB 546.20 KiB 524.61 KiB

Previous results on branch: armcknight/test/share-sdk-wrapper-xcodegen

Startup times

Revision Plain With Sentry Diff
25f3043 1213.29 ms 1233.40 ms 20.11 ms
8b02d54 1221.31 ms 1243.71 ms 22.41 ms
d01c823 1221.49 ms 1249.14 ms 27.65 ms

App size

Revision Plain With Sentry Diff
25f3043 23.76 KiB 861.21 KiB 837.45 KiB
8b02d54 23.76 KiB 861.22 KiB 837.46 KiB
d01c823 23.76 KiB 861.21 KiB 837.45 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from armcknight/test/shared-sdk-lib to main May 13, 2025 00:44
@armcknight armcknight merged commit 22de7b1 into main May 13, 2025
56 of 57 checks passed
@armcknight armcknight deleted the armcknight/test/share-sdk-wrapper-xcodegen branch May 13, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants