Skip to content

chore: Add debug logging to UIViewController performance tracker #5217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2025

Conversation

philprime
Copy link
Contributor

Adds logging statements to the UIViewController performance tracker

Derived from #5048

#skip-changelog

@philprime philprime self-assigned this May 9, 2025
philprime added a commit that referenced this pull request May 9, 2025
Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.757%. Comparing base (7b987c8) to head (8a0960a).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5217       +/-   ##
=============================================
+ Coverage   92.752%   92.757%   +0.005%     
=============================================
  Files          677       677               
  Lines        84695     84726       +31     
  Branches     30802     30815       +13     
=============================================
+ Hits         78557     78590       +33     
+ Misses        6036      6035        -1     
+ Partials       102       101        -1     
Files with missing lines Coverage Δ
.../Sentry/SentryUIViewControllerPerformanceTracker.m 99.395% <100.000%> (+0.066%) ⬆️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b987c8...8a0960a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented May 9, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.27 ms 1243.29 ms 22.02 ms
Size 23.76 KiB 863.88 KiB 840.12 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
1ee5a37 1209.37 ms 1222.04 ms 12.68 ms
7f691b5 1233.94 ms 1243.80 ms 9.86 ms
e070f8a 1236.47 ms 1250.50 ms 14.03 ms
c8dbe73 1215.37 ms 1237.31 ms 21.94 ms
aeec206 1229.27 ms 1253.70 ms 24.43 ms
c810e58 1221.57 ms 1250.45 ms 28.88 ms
034be1c 1222.67 ms 1236.22 ms 13.55 ms
533859f 1237.78 ms 1249.76 ms 11.98 ms
4977fbc 1231.55 ms 1239.80 ms 8.25 ms
742d4b6 1204.00 ms 1217.90 ms 13.90 ms

App size

Revision Plain With Sentry Diff
1ee5a37 21.58 KiB 670.39 KiB 648.81 KiB
7f691b5 20.76 KiB 420.55 KiB 399.79 KiB
e070f8a 21.58 KiB 546.20 KiB 524.62 KiB
c8dbe73 21.58 KiB 615.91 KiB 594.33 KiB
aeec206 20.76 KiB 434.88 KiB 414.12 KiB
c810e58 22.32 KiB 761.10 KiB 738.78 KiB
034be1c 20.76 KiB 436.66 KiB 415.90 KiB
533859f 22.85 KiB 408.84 KiB 386.00 KiB
4977fbc 20.76 KiB 419.86 KiB 399.10 KiB
742d4b6 21.58 KiB 546.20 KiB 524.61 KiB

Previous results on branch: philprime/uiviewcontrollerperformance-logging

Startup times

Revision Plain With Sentry Diff
d7e0a6a 1239.86 ms 1259.40 ms 19.54 ms

App size

Revision Plain With Sentry Diff
d7e0a6a 23.76 KiB 863.92 KiB 840.16 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about the prefix and a change that looks like a bugfix. The rest LGTM, thanks for adding better logs.

@philprime philprime requested a review from philipphofmann May 12, 2025 14:28
Copy link
Member

@armcknight armcknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a simple man, I see only SENTRY_LOG_DEBUG, I hit approve ✔️ Thanks for adding these!

@philprime philprime merged commit fb7270c into main May 13, 2025
84 of 86 checks passed
@philprime philprime deleted the philprime/uiviewcontrollerperformance-logging branch May 13, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants