-
-
Notifications
You must be signed in to change notification settings - Fork 352
chore: Add debug logging to UIViewController performance tracker #5217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add debug logging to UIViewController performance tracker #5217
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5217 +/- ##
=============================================
+ Coverage 92.752% 92.757% +0.005%
=============================================
Files 677 677
Lines 84695 84726 +31
Branches 30802 30815 +13
=============================================
+ Hits 78557 78590 +33
+ Misses 6036 6035 -1
+ Partials 102 101 -1
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1ee5a37 | 1209.37 ms | 1222.04 ms | 12.68 ms |
7f691b5 | 1233.94 ms | 1243.80 ms | 9.86 ms |
e070f8a | 1236.47 ms | 1250.50 ms | 14.03 ms |
c8dbe73 | 1215.37 ms | 1237.31 ms | 21.94 ms |
aeec206 | 1229.27 ms | 1253.70 ms | 24.43 ms |
c810e58 | 1221.57 ms | 1250.45 ms | 28.88 ms |
034be1c | 1222.67 ms | 1236.22 ms | 13.55 ms |
533859f | 1237.78 ms | 1249.76 ms | 11.98 ms |
4977fbc | 1231.55 ms | 1239.80 ms | 8.25 ms |
742d4b6 | 1204.00 ms | 1217.90 ms | 13.90 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1ee5a37 | 21.58 KiB | 670.39 KiB | 648.81 KiB |
7f691b5 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
e070f8a | 21.58 KiB | 546.20 KiB | 524.62 KiB |
c8dbe73 | 21.58 KiB | 615.91 KiB | 594.33 KiB |
aeec206 | 20.76 KiB | 434.88 KiB | 414.12 KiB |
c810e58 | 22.32 KiB | 761.10 KiB | 738.78 KiB |
034be1c | 20.76 KiB | 436.66 KiB | 415.90 KiB |
533859f | 22.85 KiB | 408.84 KiB | 386.00 KiB |
4977fbc | 20.76 KiB | 419.86 KiB | 399.10 KiB |
742d4b6 | 21.58 KiB | 546.20 KiB | 524.61 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure about the prefix and a change that looks like a bugfix. The rest LGTM, thanks for adding better logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a simple man, I see only SENTRY_LOG_DEBUG
, I hit approve ✔️ Thanks for adding these!
Adds logging statements to the UIViewController performance tracker
Derived from #5048
#skip-changelog