Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 21, 2025

Remove this setting that is deprecated and removed in the v9 flag

#skip-changelog

Closes #6544

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.776%. Comparing base (22af3fc) to head (51eada2).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6492       +/-   ##
=============================================
+ Coverage   85.513%   85.776%   +0.263%     
=============================================
  Files          451       451               
  Lines        27328     27321        -7     
  Branches     11913     11912        -1     
=============================================
+ Hits         23369     23435       +66     
+ Misses        3914      3841       -73     
  Partials        45        45               
Files with missing lines Coverage Δ
SentryTestUtils/TestOptions.swift 100.000% <100.000%> (ø)
Sources/Sentry/SentryOptions.m 96.407% <ø> (-0.085%) ⬇️
Sources/Sentry/SentrySDKInternal.m 83.266% <ø> (-3.452%) ⬇️
Sources/Sentry/SentyOptionsInternal.m 99.543% <ø> (-0.017%) ⬇️

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22af3fc...51eada2. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1220.77 ms 1260.15 ms 39.38 ms
Size 23.75 KiB 1.00 MiB 1002.23 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7629df7 1224.80 ms 1250.29 ms 25.49 ms
db9572a 1223.13 ms 1241.60 ms 18.47 ms
76f74df 1238.29 ms 1261.22 ms 22.94 ms
9450cb4 1221.29 ms 1232.96 ms 11.67 ms
701b301 1226.10 ms 1245.57 ms 19.47 ms
079bcc8 1217.88 ms 1234.88 ms 17.00 ms
fdea6f5 1216.08 ms 1241.82 ms 25.73 ms
c30e401 1218.71 ms 1243.73 ms 25.02 ms
934eee4 1222.51 ms 1251.04 ms 28.53 ms
aa96485 1215.37 ms 1234.04 ms 18.67 ms

App size

Revision Plain With Sentry Diff
7629df7 23.75 KiB 959.45 KiB 935.70 KiB
db9572a 23.75 KiB 858.64 KiB 834.89 KiB
76f74df 23.75 KiB 879.61 KiB 855.86 KiB
9450cb4 23.75 KiB 908.55 KiB 884.80 KiB
701b301 23.75 KiB 867.16 KiB 843.41 KiB
079bcc8 23.74 KiB 874.07 KiB 850.33 KiB
fdea6f5 23.75 KiB 867.15 KiB 843.40 KiB
c30e401 23.74 KiB 971.70 KiB 947.96 KiB
934eee4 23.75 KiB 988.03 KiB 964.28 KiB
aa96485 23.75 KiB 874.46 KiB 850.71 KiB

Previous results on branch: removeDeprecatedIntegrations

Startup times

Revision Plain With Sentry Diff
75209a9 1217.91 ms 1248.78 ms 30.87 ms
ff29e12 1214.66 ms 1248.91 ms 34.25 ms
2b2ee5a 1237.29 ms 1265.98 ms 28.69 ms
d35abd8 1219.20 ms 1258.71 ms 39.50 ms

App size

Revision Plain With Sentry Diff
75209a9 23.75 KiB 1.00 MiB 1005.77 KiB
ff29e12 23.75 KiB 1.01 MiB 1006.39 KiB
2b2ee5a 23.75 KiB 1.00 MiB 1005.77 KiB
d35abd8 23.75 KiB 1.01 MiB 1008.62 KiB

@noahsmartin noahsmartin force-pushed the removeDeprecatedIntegrations branch 3 times, most recently from 87033d4 to 310a2a6 Compare October 23, 2025 16:50
@noahsmartin noahsmartin marked this pull request as ready for review October 27, 2025 15:34
cursor[bot]

This comment was marked as outdated.

@noahsmartin noahsmartin force-pushed the removeDeprecatedIntegrations branch from 310a2a6 to 85715ad Compare October 27, 2025 16:32
cursor[bot]

This comment was marked as outdated.

@noahsmartin noahsmartin force-pushed the removeDeprecatedIntegrations branch from 85715ad to 51eada2 Compare October 27, 2025 16:49
Copy link
Contributor

@itaybre itaybre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ref: Remove deprecated integrations option

2 participants