-
-
Notifications
You must be signed in to change notification settings - Fork 369
ci: Add logs to calling xcodebuild #6506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Include timestamps to ci-utils.sh to know when the echo methods are called and log message just before calling xcodebuild to identify if this command is handing in CI, because we frequently see running tests timing out in CI.
Bug: Timestamp Function Fails on macOSThe get_timestamp() function uses |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6506 +/- ##
=============================================
+ Coverage 86.891% 86.933% +0.042%
=============================================
Files 451 451
Lines 37547 37547
Branches 17388 17390 +2
=============================================
+ Hits 32625 32641 +16
+ Misses 4643 4630 -13
+ Partials 279 276 -3 see 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Bug: Inconsistent Timestamps in Log OutputThe begin_group() function calls get_timestamp() twice in the non-GitHub Actions branch, which could result in different timestamps being displayed for a single logical operation. The two echo statements on lines 47-48 may show different times if executed in different seconds, making log analysis confusing. A single timestamp should be captured and reused for consistency. |
|
For future reference, here are the GitHub workflow commands documented: https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-commands |
Bug: GitHub Actions Command Format ErrorThe GitHub Actions workflow commands have an incorrect format with an extra space after the command prefix. The lines contain "::notice:: [" and "::warning:: [" and "::error:: [" but GitHub Actions expects the format "::notice::[message]" without the space after the double colons. This extra space will cause GitHub Actions to not recognize these as workflow commands, preventing proper log formatting and potentially breaking CI integrations that rely on these commands. |
I added that info to the ci-utils.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Include timestamps to ci-utils.sh to know when the echo methods are called and log message just before calling xcodebuild to identify if this command is handing in CI, because we frequently see running tests timing out in CI.
#skip-changelog
Closes #6507