Skip to content

Conversation

@philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Oct 23, 2025

Include timestamps to ci-utils.sh to know when the echo methods are called and log message just before calling xcodebuild to identify if this command is handing in CI, because we frequently see running tests timing out in CI.

#skip-changelog

Closes #6507

Include timestamps to ci-utils.sh to know when the echo methods are
called and log message just before calling xcodebuild to identify if
this command is handing in CI, because we frequently see running tests
timing out in CI.
@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Timestamp Function Fails on macOS

The get_timestamp() function uses date +"%T.%3N" which includes the %3N format specifier (first 3 digits of nanoseconds for milliseconds). This is a GNU-specific extension that is not supported by BSD date, which is the default on macOS. On macOS systems or other environments with BSD date, this will cause the function to fail with an "invalid conversion specification" error, breaking all logging functions that depend on it. GitHub Actions macOS runners use BSD date by default, which means this code could fail in CI environments running on macOS.

Fix in Cursor Fix in Web

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.933%. Comparing base (debf3e9) to head (181e5f7).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6506       +/-   ##
=============================================
+ Coverage   86.891%   86.933%   +0.042%     
=============================================
  Files          451       451               
  Lines        37547     37547               
  Branches     17388     17390        +2     
=============================================
+ Hits         32625     32641       +16     
+ Misses        4643      4630       -13     
+ Partials       279       276        -3     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update debf3e9...181e5f7. Read the comment docs.

@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Inconsistent Timestamps in Log Output

The begin_group() function calls get_timestamp() twice in the non-GitHub Actions branch, which could result in different timestamps being displayed for a single logical operation. The two echo statements on lines 47-48 may show different times if executed in different seconds, making log analysis confusing. A single timestamp should be captured and reused for consistency.

Fix in Cursor Fix in Web

@philprime
Copy link
Member

For future reference, here are the GitHub workflow commands documented:

https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-commands

@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: GitHub Actions Command Format Error

The GitHub Actions workflow commands have an incorrect format with an extra space after the command prefix. The lines contain "::notice:: [" and "::warning:: [" and "::error:: [" but GitHub Actions expects the format "::notice::[message]" without the space after the double colons. This extra space will cause GitHub Actions to not recognize these as workflow commands, preventing proper log formatting and potentially breaking CI integrations that rely on these commands.

Fix in Cursor Fix in Web

@philipphofmann
Copy link
Member Author

For future reference, here are the GitHub workflow commands documented:

https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-commands

I added that info to the ci-utils.sh

Copy link
Contributor

@itaybre itaybre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipphofmann philipphofmann merged commit 6b01cf3 into main Oct 24, 2025
141 of 143 checks passed
@philipphofmann philipphofmann deleted the ci/logs-xcodebuild branch October 24, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: Add logs to calling xcodebuild

3 participants