Skip to content

Conversation

@philipphofmann
Copy link
Member

📜 Description

Remove uuid and name from SentryDebugMeta as they aren't available in the protocol, and we kept them for backwards compatibility since #2701.

💡 Motivation and Context

Fixes GH-2702

💚 How did you test it?

Unit tests still green.

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Remove uuid and name from SentryDebugMeta as they aren't available in
the protocol and we kept them for backwards compatibility since #2701.

Fixes GH-2702
Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.926%. Comparing base (debf3e9) to head (e5cf443).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6512       +/-   ##
=============================================
+ Coverage   86.891%   86.926%   +0.035%     
=============================================
  Files          451       451               
  Lines        37547     37543        -4     
  Branches     17388     17386        -2     
=============================================
+ Hits         32625     32635       +10     
+ Misses        4643      4632       -11     
+ Partials       279       276        -3     
Files with missing lines Coverage Δ
Sources/Sentry/SentryDebugMeta.m 100.000% <ø> (ø)
...wift/Protocol/Codable/SentryDebugMetaCodable.swift 100.000% <100.000%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update debf3e9...e5cf443. Read the comment docs.

@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1232.43 ms 1259.72 ms 27.30 ms
Size 23.75 KiB 1.00 MiB 1006.01 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5c5648e 1234.44 ms 1253.79 ms 19.35 ms
fb48c9a 1232.49 ms 1266.27 ms 33.78 ms
d72784d 1214.31 ms 1241.35 ms 27.04 ms
7af87c1 1229.31 ms 1253.84 ms 24.53 ms
029a804 1219.65 ms 1241.96 ms 22.30 ms
139db8b 1231.50 ms 1258.19 ms 26.69 ms
7f4bf81 1241.73 ms 1270.66 ms 28.93 ms
83bb978 1238.33 ms 1260.04 ms 21.71 ms
42cfd79 1222.13 ms 1244.23 ms 22.10 ms
aac24ac 1225.94 ms 1256.38 ms 30.45 ms

App size

Revision Plain With Sentry Diff
5c5648e 23.75 KiB 879.60 KiB 855.86 KiB
fb48c9a 23.75 KiB 1006.34 KiB 982.59 KiB
d72784d 23.75 KiB 988.01 KiB 964.27 KiB
7af87c1 23.75 KiB 933.34 KiB 909.59 KiB
029a804 23.75 KiB 928.11 KiB 904.36 KiB
139db8b 23.75 KiB 920.64 KiB 896.89 KiB
7f4bf81 23.75 KiB 919.70 KiB 895.95 KiB
83bb978 23.75 KiB 920.64 KiB 896.89 KiB
42cfd79 23.75 KiB 880.20 KiB 856.45 KiB
aac24ac 23.75 KiB 1019.17 KiB 995.42 KiB

@philipphofmann philipphofmann merged commit 5fc3364 into main Oct 23, 2025
174 of 178 checks passed
@philipphofmann philipphofmann deleted the fix/remove-not-needed-debug-meta-fields branch October 23, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove not needed SentryDebugMeta fields

3 participants