-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Updates the Unity SDK docs with new SetData methods on spans & transa… #13457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@lukemun is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Luke!! Some small notes but generally lgtm.
I'll leave it out to @Flash0ver to do the final 🟢
… into unity-set-data
trying to push changes to see whether a preview deployment kicks off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lukemun for improving our Unity docs.
Thank you very much indeed. You may have revealed a bug in our .NET SDK.
I also left some notes.
Please mind: I made a "trailing-space-removing" push to the PR in order to kick off the preview deployment.
Co-authored-by: Stefan Pölz <[email protected]>
… sample in favor of trace
@getsentry/docs Am I allowed to approve and run the required workflows, or is this something that the docs owners should do? @lukemun I kicked off another |
Hey @Flash0ver , you need certain Vercel permissions to run the builds, if you have those perms, feel free to do so. I went ahead and kicked them off for this PR. |
DESCRIBE YOUR PR
Updates the Unity SDK docs with new SetData methods on spans & transactions
SDK changes: getsentry/sentry-dotnet#3936
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES