Skip to content

Updates the Unity SDK docs with new SetData methods on spans & transa… #13457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 13, 2025

Conversation

lukemun
Copy link
Contributor

@lukemun lukemun commented Apr 21, 2025

DESCRIBE YOUR PR

Updates the Unity SDK docs with new SetData methods on spans & transactions

SDK changes: getsentry/sentry-dotnet#3936

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Apr 21, 2025

@lukemun is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Apr 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 8:20pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview May 8, 2025 8:20pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview May 8, 2025 8:20pm

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Luke!! Some small notes but generally lgtm.

I'll leave it out to @Flash0ver to do the final 🟢

@bruno-garcia bruno-garcia requested a review from Flash0ver April 23, 2025 21:19
trying to push changes to see whether a preview deployment kicks off
Copy link
Member

@Flash0ver Flash0ver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lukemun for improving our Unity docs.
Thank you very much indeed. You may have revealed a bug in our .NET SDK.

I also left some notes.
Please mind: I made a "trailing-space-removing" push to the PR in order to kick off the preview deployment.

@Flash0ver Flash0ver requested a review from a team May 7, 2025 16:46
@Flash0ver
Copy link
Member

Flash0ver commented May 7, 2025

@getsentry/docs Am I allowed to approve and run the required workflows, or is this something that the docs owners should do?

@lukemun I kicked off another sentry-docs Preview. Thanks for the changes.

@coolguyzone
Copy link
Contributor

Hey @Flash0ver , you need certain Vercel permissions to run the builds, if you have those perms, feel free to do so. I went ahead and kicked them off for this PR.

@coolguyzone coolguyzone merged commit e900fed into getsentry:master May 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants