Skip to content

Prevent users building with AndroidEnableAssemblyCompression set to false #4089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 10, 2025

Conversation

aritchie
Copy link
Collaborator

@aritchie aritchie commented Apr 7, 2025

Resolve #3920 when users set AndroidEnableAssemblyCompression to false

This issue is specific to the .NET Android SDK. We can't detect the issue during runtime, nor can we trap it without the entire Sentry SDK having issues around missing DSN. As such, we're implementing a target to prevent users from disabling this flag.

A few notes

  • This blocks debug AND release builds with this flag set to false even though the issue is specific to it being only on release builds. We want to notify users as early in the dev loop as possible
  • This issue has only been seen in NET9, however, MAUI and mobile do not have an LTS and NET9 is considered current stable

Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aritchie aritchie merged commit 5b0b144 into main Apr 10, 2025
25 of 27 checks passed
@aritchie aritchie deleted the 3920-prevent_android_compression branch April 10, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initializing SentrySdk Crashes when running with AndroidEnableAssemblyCompression = false in Release mode
2 participants