WIP: fix: support musl on Linux #4182
Conversation
jpnurmi
force-pushed
the
fix/musl
branch
15 times, most recently
from
8bd1848 to
c7d9c64
Compare
.github/workflows/build.yml
Outdated
| uses: actions/cache/restore@v4 | ||
| with: | ||
| path: src/Sentry/Platforms/Native/sentry-native | ||
| key: sentry-native-alpine:3.21-${{ hashFiles('scripts/build-sentry-native.ps1') }}-${{ hashFiles('.git/modules/modules/sentry-native/HEAD') }} |
There was a problem hiding this comment.
Maybe use ${{ !matrix.runner.container }} here instead of hard coding alpine:3.21?
There was a problem hiding this comment.
I resorted to temporarily hard-coding it because the macOS publishing job doesn't have matrix.runner.container defined. How about defining a helper "target" variable in the matrix so that one could use something prettier like 'Linux-musl' as a cache key? At the same time, it could help selecting a different .slnf because the Android SDK Build-Tools contain musl-incompatible prebuilt binaries... 🙁
|
Looks like an awesome start @jpnurmi - massive thank you 🚀 ❤️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4182 +/- ##
==========================================
- Coverage 75.73% 72.94% -2.79%
==========================================
Files 357 452 +95
Lines 13466 16439 +2973
Branches 2671 3283 +612
==========================================
+ Hits 10198 11992 +1794
- Misses 2593 3608 +1015
- Partials 675 839 +164 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Superseded by #4188 |
WIP
See also: