Skip to content

build on windows-11-arm #4187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

build on windows-11-arm #4187

wants to merge 32 commits into from

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented May 13, 2025

Since I tried my luck with:
* getsentry/sentry-native#880

Blocked by:

A lot was figured out by @jpnurmi when adding musl Linux, so I just copied over

TODO:

  • Test with env.CI_PUBLISHING_BUILD set to true
  • Plugin the actual sentry-native arm64 build when available, for Native AOT support

@bruno-garcia bruno-garcia marked this pull request as draft May 17, 2025 21:17
@bruno-garcia bruno-garcia mentioned this pull request May 18, 2025
8 tasks
@bruno-garcia
Copy link
Member Author

/Users/runner/.dotnet/sdk/9.0.203/Sdks/NuGet.Build.Tasks.Pack/buildCrossTargeting/NuGet.Build.Tasks.Pack.targets(221,5): error : Could not find a part of the path '/Users/runner/work/sentry-dotnet/sentry-dotnet/src/Sentry/Platforms/Native/sentry-native/win-arm64'. [/Users/runner/work/sentry-dotnet/sentry-dotnet/src/Sentry/Sentry.csproj]

I think now the only thing left is building sentry-native for Windows arm64 which is being done on:

jpnurmi added 2 commits May 19, 2025 20:16
Downloads are separate steps because
macOS (CI_PUBLISHING_BUILD) needs to download both.
@jpnurmi
Copy link
Collaborator

jpnurmi commented May 19, 2025

Does actions/cache with enableCrossOsArchive not work on windows-11-arm?

  1. sentry-native build succeeds on windows-11-arm and it saves the cache.
  2. The cache artifact is visible at https://github.com/getsentry/sentry-dotnet/actions/caches
  3. .NET build for windows-11-arm manages to restore the cache.
  4. .NET build for macOS (CI_PUBLISHING_BUILD=true) does not find the same cache entry.

@jpnurmi
Copy link
Collaborator

jpnurmi commented May 19, 2025

Does actions/cache with enableCrossOsArchive not work on windows-11-arm?

@bruno-garcia bruno-garcia marked this pull request as ready for review May 19, 2025 23:53
@jpnurmi
Copy link
Collaborator

jpnurmi commented May 20, 2025

@jamescrosswell @Flash0ver On behalf of @bruno-garcia, I've fixed the remaining issues with cache keys etc. to make the CI pass. Once everything looks good, I'd propose merging this PR first, and then we can proceed with the musl PR that has some overlap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants