fix: Throw ArgumentException for empty traceId in DynamicSamplingContext - #5599
Merged
jamescrosswell merged 1 commit intoSep 21, 2026
Merged
jamescrosswell merged 1 commit into
jamescrosswell merged 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5599 +/- ##
==========================================
+ Coverage 74.81% 74.84% +0.03%
==========================================
Files 515 515
Lines 18963 18963
Branches 3694 3694
==========================================
+ Hits 14187 14193 +6
+ Misses 3894 3892 -2
+ Partials 882 878 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jamescrosswell
approved these changes
Sep 21, 2026
jamescrosswell
left a comment
Collaborator
There was a problem hiding this comment.
Great - thanks @chiliec !
3 tasks
This was referenced Oct 1, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5169
DynamicSamplingContextthrowsArgumentOutOfRangeExceptionwhentraceIdisSentryId.Empty.ArgumentOutOfRangeExceptionis meant for values outside a numeric/ordinal range; an empty id is an invalid argument, so this changes it toArgumentException(same message, sameparamName), matching thepublicKeycheck right below it. ThesampleRate/sampleRandrange checks are left asArgumentOutOfRangeExceptionsince those really are range checks.Adds
CreateFromPropagationContext_TraceId_Empty_ThrowstoDynamicSamplingContextTests, which reaches the constructor viaSentryPropagationContext(SentryId.Empty, ...).Verified locally (Linux, .NET SDK 10.0.401,
net10.0):With the source change reverted the new test fails as expected (
Expected: ArgumentException, Actual: ArgumentOutOfRangeException).Only
net10.0was run here (no Android/iOS workloads on this machine).