-
-
Notifications
You must be signed in to change notification settings - Fork 461
feat(logging): Log Timber tag as log attribute #4845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+29
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sentry review |
|
Seer had some issues with your request. Please try again. |
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 27d7cf8 | 309.43 ms | 364.27 ms | 54.85 ms |
| 3d205d0 | 352.15 ms | 432.53 ms | 80.38 ms |
| ee747ae | 554.98 ms | 611.50 ms | 56.52 ms |
| ce0a49e | 532.00 ms | 609.96 ms | 77.96 ms |
| b3d8889 | 420.46 ms | 453.71 ms | 33.26 ms |
| 27d7cf8 | 306.76 ms | 366.66 ms | 59.90 ms |
| 806307f | 357.85 ms | 424.64 ms | 66.79 ms |
| c8125f3 | 397.65 ms | 485.14 ms | 87.49 ms |
| d5a29b6 | 298.62 ms | 391.78 ms | 93.16 ms |
| d364ace | 384.53 ms | 453.51 ms | 68.98 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 27d7cf8 | 1.58 MiB | 2.12 MiB | 549.42 KiB |
| 3d205d0 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ce0a49e | 1.58 MiB | 2.10 MiB | 532.94 KiB |
| b3d8889 | 1.58 MiB | 2.10 MiB | 535.07 KiB |
| 27d7cf8 | 1.58 MiB | 2.12 MiB | 549.42 KiB |
| 806307f | 1.58 MiB | 2.10 MiB | 533.42 KiB |
| c8125f3 | 1.58 MiB | 2.10 MiB | 532.32 KiB |
| d5a29b6 | 1.58 MiB | 2.12 MiB | 549.37 KiB |
| d364ace | 1.58 MiB | 2.11 MiB | 539.75 KiB |
|
@sentry review |
|
romtsn
reviewed
Oct 29, 2025
sentry-android-timber/src/main/java/io/sentry/android/timber/SentryTimberTree.kt
Show resolved
Hide resolved
romtsn
approved these changes
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one Q
|
@sentry review |
|
Seer had some issues with your request. Please try again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Tags supplied via Timber
now get reported as a
timber.tagattribute.💡 Motivation and Context
Better logging
💚 How did you test it?
Added unit tests
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps