Skip to content

Do not log if sentry.properties in rundir has not been found #4929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 24, 2025
Merged

Do not log if sentry.properties in rundir has not been found #4929

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f10f1c
Do not log if sentry.properties in rundir has not been found
adinauer Nov 24, 2025
bfe3d16
Format code
getsentry-bot Nov 24, 2025
d359228
changelog
adinauer Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions sentry/src/main/java/io/sentry/config/FilesystemPropertiesLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,17 @@
final class FilesystemPropertiesLoader implements PropertiesLoader {
private final @NotNull String filePath;
private final @NotNull ILogger logger;
private boolean logNonExisting;

public FilesystemPropertiesLoader(@NotNull String filePath, @NotNull ILogger logger) {
this(filePath, logger, true);
}

public FilesystemPropertiesLoader(
@NotNull String filePath, @NotNull ILogger logger, boolean logNonExisting) {
this.filePath = filePath;
this.logger = logger;
this.logNonExisting = logNonExisting;
}

@Override
Expand All @@ -31,10 +38,12 @@ public FilesystemPropertiesLoader(@NotNull String filePath, @NotNull ILogger log
return properties;
}
} else if (!f.isFile()) {
logger.log(
SentryLevel.ERROR,
"Failed to load Sentry configuration since it is not a file or does not exist: %s",
filePath);
if (logNonExisting) {
logger.log(
SentryLevel.ERROR,
"Failed to load Sentry configuration since it is not a file or does not exist: %s",
filePath);
}
} else if (!f.canRead()) {
logger.log(
SentryLevel.ERROR,
Expand Down
2 changes: 1 addition & 1 deletion sentry/src/main/java/io/sentry/config/PropertiesProviderFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public final class PropertiesProviderFactory {
}

final Properties runDirectoryProperties =
new FilesystemPropertiesLoader("sentry.properties", logger).load();
new FilesystemPropertiesLoader("sentry.properties", logger, false).load();
if (runDirectoryProperties != null) {
providers.add(new SimplePropertiesProvider(runDirectoryProperties));
}
Expand Down