-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ci(release): Switch from action-prepare-release to Craft #18763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BYK
wants to merge
24
commits into
develop
Choose a base branch
from
ci/migrate-to-craft-action
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
b9ae430
ci(release): Switch from action-prepare-release to Craft
BYK 3c240d2
ci(release): Restore GitHub App token authentication
BYK f101fbf
ci(release): Restore GitHub App token authentication
BYK a8c5f38
fix: Pin actions to SHA and add permissions blocks
BYK 95d4e72
fix: Restore PR trigger and version extraction for auto-release
BYK f88812d
fix: Use correct action version SHAs (restore original versions)
BYK d17ff7e
fix: Use correct action version SHAs (restore original versions)
BYK a902463
fix: Address review feedback (inputs context, permissions, triggers)
BYK 5348f80
fix: Add Node.js setup to release workflow
BYK e912696
fix: Clean up action version comments
BYK 480fe95
Update Craft SHA to 1c58bfd57bfd6a967b6f3fc92bead2c42ee698ce
BYK 91807f2
Update Craft SHA to 1c58bfd57bfd6a967b6f3fc92bead2c42ee698ce
BYK fbb531f
Add explicit permissions block to build.yml
BYK b4ba2d3
Add explicit permissions block to codeql-analysis.yml
BYK e07b23e
Add explicit permissions block to create-issue-for-unreferenced-prs.yml
BYK c15b599
Add explicit permissions block to enforce-license-compliance.yml
BYK e26bc72
Revert permissions changes to build.yml
BYK df2832a
Revert permissions changes to codeql-analysis.yml
BYK 657b2e0
Revert permissions changes to create-issue-for-unreferenced-prs.yml
BYK 64e73aa
Revert permissions changes to enforce-license-compliance.yml
BYK 0b2d1e4
fix: revert extraneous changes to non-release workflow files
BYK 6855820
fix: clean up release.yml formatting and version comments
BYK 0ad41f4
build(craft): Update Craft action to c6e2f04
BYK ec4ad57
chore: add unlabeled trigger to changelog-preview
BYK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| name: Changelog Preview | ||
| on: | ||
| pull_request: | ||
| types: | ||
| - opened | ||
| - synchronize | ||
| - reopened | ||
| - edited | ||
| - labeled | ||
| - unlabeled | ||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
|
|
||
| jobs: | ||
| changelog-preview: | ||
| uses: getsentry/craft/.github/workflows/changelog-preview.yml@v2 | ||
| secrets: inherit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional version input lacks default value
Low Severity
The
versioninput was changed fromrequired: truetorequired: false, with the description updated to "(or 'auto')". However, nodefaultvalue was added. If a user triggers the workflow without providing a version,github.event.inputs.versionpasses an empty string to the Craft action rather than "auto". This could cause unexpected behavior if Craft doesn't treat empty strings equivalently to "auto" versioning.