feat(langchain): Broaden AI provider detection beyond OpenAI and Anthropic by ericapisani · Pull Request #5707 · getsentry/sentry-python

ericapisani · 2026-03-19T12:07:07Z

Summary

Extracts a _get_ai_system() helper that generically detects AI providers from LangChain's _type field, replacing hardcoded "anthropic" / "openai" checks.
Adds support for Cohere, Ollama, Mistral, Fireworks, HuggingFace, Groq, NVIDIA, xAI, DeepSeek, Google, and any future LangChain providers without code changes.

Test plan

Parametrized test with coverage for real LangChain _llm_type values from various providers
CI passes

🤖 Generated with Claude Code

…ropic Extract _get_ai_system() to generically detect AI providers from LangChain's _type field instead of hardcoding only "anthropic" and "openai". The function splits on "-" and skips non-provider segments (cloud prefixes like "azure" and descriptors like "chat"/"llm") to return the actual provider name. This adds support for Cohere, Ollama, Mistral, Fireworks, HuggingFace, Groq, NVIDIA, xAI, DeepSeek, Google, and any future LangChain providers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

ericapisani · 2026-03-19T12:07:53Z

@cursoragent please review this

cursor · 2026-03-19T12:07:58Z

Please finish setting up background agents. Go to Cursor

github-actions · 2026-03-19T12:11:25Z

Codecov Results 📊

✅ 7 passed | Total: 7 | Pass Rate: 100% | Execution Time: 3.15s

All tests are passing successfully.

❌ Patch coverage is 0.00%. Project has 15257 uncovered lines.

Files with missing lines (1)

File	Patch %	Lines
`langchain.py`	3.27%	⚠️ 591 Missing

Generated by Codecov Action

github-actions · 2026-03-19T12:11:25Z

Codecov Results 📊

✅ 9 passed | ⏭️ 1 skipped | Total: 10 | Pass Rate: 90% | Execution Time: 3.63s

All tests are passing successfully.

❌ Patch coverage is 0.00%. Project has 14771 uncovered lines.

Files with missing lines (1)

File	Patch %	Lines
`langchain.py`	3.24%	⚠️ 598 Missing

Generated by Codecov Action

ericapisani · 2026-03-20T09:29:58Z

bugbot run

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

…s-is Remove string splitting and filtering logic from _get_ai_system. The function now returns the LangChain _type value directly without attempting to extract a provider name from it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-03-20T10:25:20Z

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

New Features ✨

Langchain

Broaden AI provider detection beyond OpenAI and Anthropic by ericapisani in #5707

Update LLM span operation to gen_ai.generate_text by ericapisani in #5796

Internal Changes 🔧

Langchain

Add text completion test by alexander-alderman-webb in #5740
Add tool execution test by alexander-alderman-webb in #5739
Add basic agent test with Responses call by alexander-alderman-webb in #5726
Replace mocks with httpx types by alexander-alderman-webb in #5724
Consolidate span origin assertion by alexander-alderman-webb in #5723
Consolidate available tools assertion by alexander-alderman-webb in #5721

Other

Temporarily stop running litellm tests by alexander-alderman-webb in #5851

_{🤖 This preview updates automatically when you update the PR.}

sentry_sdk/integrations/langchain.py

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Autofix Details

Bugbot Autofix prepared a fix for the issue found in the latest run.

✅ Fixed: Raw _type values break gen_ai.system consistency with other integrations
- Restored normalization of LangChain _type values to return 'openai' and 'anthropic' instead of raw values like 'openai-chat' and 'anthropic-chat', matching the dedicated integrations and maintaining backward compatibility.

Or push these changes by commenting:

@cursor push 98e51d01de

Preview (98e51d01de)

diff --git a/sentry_sdk/integrations/langchain.py b/sentry_sdk/integrations/langchain.py
--- a/sentry_sdk/integrations/langchain.py
+++ b/sentry_sdk/integrations/langchain.py
@@ -114,6 +114,11 @@
     if not ai_type or not isinstance(ai_type, str):
         return None
 
+    if "anthropic" in ai_type:
+        return "anthropic"
+    elif "openai" in ai_type:
+        return "openai"
+
     return ai_type
 
 

diff --git a/tests/integrations/langchain/test_langchain.py b/tests/integrations/langchain/test_langchain.py
--- a/tests/integrations/langchain/test_langchain.py
+++ b/tests/integrations/langchain/test_langchain.py
@@ -2005,13 +2005,13 @@
     [
         # Real LangChain _type values (from _llm_type properties)
         # OpenAI
-        ("openai-chat", "openai-chat"),
+        ("openai-chat", "openai"),
         ("openai", "openai"),
         # Azure OpenAI
-        ("azure-openai-chat", "azure-openai-chat"),
+        ("azure-openai-chat", "openai"),
         ("azure", "azure"),
         # Anthropic
-        ("anthropic-chat", "anthropic-chat"),
+        ("anthropic-chat", "anthropic"),
         # Google
         ("vertexai", "vertexai"),
         ("chat-google-generative-ai", "chat-google-generative-ai"),

_{This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.}

cursor · 2026-03-24T08:27:35Z

sentry_sdk/integrations/langchain.py

+    if not ai_type or not isinstance(ai_type, str):
+        return None
+
+    return ai_type


Raw _type values break gen_ai.system consistency with other integrations

Medium Severity

_get_ai_system returns the raw LangChain _type value (e.g. "anthropic-chat", "openai-chat") instead of a normalized provider name. The Anthropic integration sets gen_ai.system to "anthropic" and the OpenAI integration uses "openai", matching OTel semantic conventions. The old code also normalized to these values. Now the same provider gets different gen_ai.system values depending on whether it's called directly or through LangChain, breaking filtering/grouping in the Sentry UI for existing users.

Additional Locations (1)

sentry_sdk/integrations/langchain.py#L392-L395

This is intentional, see #5707 (comment)

tests/integrations/langchain/test_langchain.py

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

tests/integrations/langchain/test_langchain.py

alexander-alderman-webb

LGTM!

ericapisani requested a review from a team as a code owner March 19, 2026 12:07

ericapisani marked this pull request as draft March 19, 2026 12:07

cursor bot reviewed Mar 20, 2026

View reviewed changes

ericapisani marked this pull request as ready for review March 20, 2026 10:26

sentry-warden bot reviewed Mar 20, 2026

View reviewed changes

sentry_sdk/integrations/langchain.py Show resolved Hide resolved

sentry bot reviewed Mar 20, 2026

View reviewed changes

sentry_sdk/integrations/langchain.py Show resolved Hide resolved

Merge branch 'master' into ep/broaden-langgraph-model-support-6d0

1bc78cc

cursor bot reviewed Mar 24, 2026

View reviewed changes

alexander-alderman-webb reviewed Mar 24, 2026

View reviewed changes

tests/integrations/langchain/test_langchain.py Show resolved Hide resolved

Merge branch 'master' into ep/broaden-langgraph-model-support-6d0

5cc615e

sentry bot reviewed Mar 25, 2026

View reviewed changes

tests/integrations/langchain/test_langchain.py Outdated Show resolved Hide resolved

cursor bot reviewed Mar 25, 2026

View reviewed changes

tests/integrations/langchain/test_langchain.py Show resolved Hide resolved

ericapisani added 2 commits March 25, 2026 10:06

Add assertions on the gen_ai.system within new langchain tests

f58a60b

Fix outdated assertion

351475f

alexander-alderman-webb approved these changes Mar 25, 2026

View reviewed changes

ericapisani merged commit 72483bb into master Mar 25, 2026
167 of 169 checks passed

ericapisani deleted the ep/broaden-langgraph-model-support-6d0 branch March 25, 2026 09:31

Conversation

ericapisani commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

ericapisani commented Mar 19, 2026

Uh oh!

cursor bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Results 📊

Uh oh!

github-actions bot commented Mar 19, 2026

Codecov Results 📊

Uh oh!

ericapisani commented Mar 20, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

New Features ✨

Langchain

Internal Changes 🔧

Langchain

Other

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cursor bot Mar 24, 2026

Choose a reason for hiding this comment

Raw _type values break gen_ai.system consistency with other integrations

Uh oh!

ericapisani Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alexander-alderman-webb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ericapisani commented Mar 19, 2026 •

edited

Loading

github-actions bot commented Mar 19, 2026 •

edited

Loading

github-actions bot commented Mar 20, 2026 •

edited

Loading

cursor bot left a comment •

edited

Loading

Raw `_type` values break `gen_ai.system` consistency with other integrations