fix(profiler): Stop nulling buffer on teardown#6075
Open
ericapisani wants to merge 1 commit intomasterfrom
Open
fix(profiler): Stop nulling buffer on teardown#6075ericapisani wants to merge 1 commit intomasterfrom
ericapisani wants to merge 1 commit intomasterfrom
Conversation
Previously, teardown() set self.buffer = None which could cause issues if the buffer was still being accessed. Keep the buffer reference intact after teardown. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 142 passed | Total: 142 | Pass Rate: 100% | Execution Time: 28.80s All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 14137 uncovered lines. Files with missing lines (1)
Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's still the occasional race condition in the GEvent tests that may be related to fast "start/stop" cycles, and the
teardownfunctions were not updated as part of #5622 (comment)These changes remove
self.buffer = Nonefromteardown()in bothThreadContinuousSchedulerandGeventContinuousSchedulerin favour of using a local variable to assignself.bufferto before setting the local variable toNoneFixes PY-2140
Fixes #5673