-
-
Notifications
You must be signed in to change notification settings - Fork 344
feat(feedback): Pull down to cancel #4534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
antonis
merged 29 commits into
feedback-ui
from
antonis/feedback-ios-pull-down-to-cancel
Feb 17, 2025
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
fe3dc15
Disable bouncing
antonis 72eef2d
Add modal ui appearance
antonis ccc808b
Update snapshot tests
antonis fd47fd2
Fix bottom margin
antonis dcc5d3b
Merge branch 'feedback-ui' into antonis/feedback-modal-ui
antonis 9ecd8a2
Fix sheet height
antonis 05f94f8
Remove extra modal border
antonis d88a599
Do not expose modal styles
antonis ce1de86
Animate background color
antonis a7a4e56
Avoid keyboard in modal
antonis 8779886
Merge branch 'feedback-ui' into antonis/feedback-modal-ui
antonis ae80f7d
Merge branch 'feedback-ui' into antonis/feedback-modal-ui
antonis 488658e
Merge branch 'feedback-ui' into antonis/feedback-modal-ui
antonis c4d502e
Use Image Picker interface matching `expo-image-picker` and `react-na…
antonis 1b74b45
Update samples to pass the ImagePicker library implementation
antonis 1d8a0db
Merge branch 'feedback-ui' into antonis/feedback-ui-imagepicker-integ…
antonis a0f4a77
Get image data from uri
antonis 357dea8
Add early return and dev note
antonis 192220b
Adds tests
antonis c3991ff
Adds sample expo plugin configuration
antonis 91e96de
Merge branch 'feedback-ui' into antonis/feedback-ui-imagepicker-integ…
antonis 6666cf6
Update media type for expo
antonis d1e5107
Update media type for rn
antonis d780fc1
Add native implementation for getDataFromUri
antonis 85dff80
Bumped to the latest react-native-image-picker version 8
antonis e92fea6
Add missing null in return type
antonis becede1
Pull down to cancel on iOS
antonis 529b703
Merge branch 'feedback-ui' into antonis/feedback-ios-pull-down-to-cancel
antonis 3238fe0
On Android allow pulling down only from the top to avoid breaking nat…
antonis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for including here the reason why.