Skip to content

test(e2e): Adds Feedback Widget Maestro E2E tests #4604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 236 commits into
base: feedback-ui-2
Choose a base branch
from
Draft

test(e2e): Adds Feedback Widget Maestro E2E tests #4604

wants to merge 236 commits into from

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Feb 26, 2025 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

Based on: #4726

PR Chain:

📜 Description

Adds Feedback Widget Maestro E2E tests for the happy path flow:

  • Show feedback button
  • Open the feedback widget
  • Fill and submit the form

💡 Motivation and Context

Part of #4302

💚 How did you test it?

CI, Manual

Note: To run Android locally you might need to change the build architecture android.patch

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

  • Add more tests outside the happy path
  • Handle RN 0.65.3

#skip-changelog

antonis and others added 30 commits November 27, 2024 14:00
@antonis
Update the client implementation to use the new capture feedback js api
817eac8
@antonis
Updates SDK API
5370a99
@antonis
Adds new feedback button in the sample
42e2fa1
@antonis
Adds changelog
514b102
@antonis
Removes unused mock
0935bbd
@antonis @krystofwoldrich
Update CHANGELOG.md
9ea5496 
Co-authored-by: Krystof Woldrich <[email protected]>
@antonis
Directly use captureFeedback from sentry/core
da0d4ac
@antonis
Use import from core
3e36c6d
@antonis
Fixes imports order lint issue
5f3df64
@antonis
Fixes build issue
71b28e8
@antonis
Adds captureFeedback tests from sentry-javascript
f9d2b59
@krystofwoldrich
Update CHANGELOG.md
d05d531
@antonis
Only deprecate client captureUserFeedback
2bb104b
@antonis
Add simple form UI
4339274
@antonis
Adds basic form functionality
6ce799b
@antonis
Update imports
f2cefc6
@antonis
Update imports
694ee33
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
18b1c33
@antonis
Remove useState hook to avoid multiple react instances issues
034efde
@antonis
Move types and styles in different files
67a492d
@antonis
Removes attachment button to be added back separately along with the …
8eaa61d 
…implementation
@antonis
Add basic field validation
0b88cc5
@antonis
Adds changelog
ae11b8d
@antonis
Updates changelog
7f2ca06
@antonis
Updates changelog
064b6c4
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
e2add4a
@antonis
Trim whitespaces from the submitted feedback
e21718a
@antonis
Adds tests
407f179
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
14ac005
@antonis
Renames FeedbackFormScreen to FeedbackForm
ddade00
@antonis antonis mentioned this pull request Apr 10, 2025
Merged
10 tasks
@antonis
Copy link
Collaborator Author

antonis commented Apr 10, 2025 •
edited
Loading

iOS tests fail to detect input and button fields.

Fixing accessibility with #4739 resolved this issue.

Base automatically changed from antonis/ios-accessibility to feedback-ui-2 April 14, 2025 14:50
@antonis antonis changed the base branch from feedback-ui-2 to antonis/capture-screenshot-error April 16, 2025 13:22
antonis added 2 commits April 16, 2025 16:22
@antonis
Merge branch 'antonis/capture-screenshot-error' into antonis/feedback…
5e7bc3d 
…-e2e

# Conflicts:
#	CHANGELOG.md
#	packages/core/android/src/oldarch/java/io/sentry/react/RNSentryModule.java
#	packages/core/src/js/feedback/FeedbackWidget.tsx
#	packages/core/src/js/feedback/ScreenshotButton.tsx
#	packages/core/src/js/tracing/reactnativeprofiler.tsx
#	packages/core/test/feedback/ScreenshotButton.test.tsx
#	packages/core/test/feedback/__snapshots__/FeedbackWidgetManager.test.tsx.snap
@antonis
Revert unneeded change
accfccf
Base automatically changed from antonis/capture-screenshot-error to feedback-ui-2 April 17, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich will be requested when the pull request is marked ready for review krystofwoldrich is a code owner

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman will be requested when the pull request is marked ready for review lucas-zimerman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonis @krystofwoldrich