Fix: V7 - JavaScript V9 - set undefined for updateProd when not set

[lucas-zimerman]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

📜 Description

• Added tests to the wrap function that were missing.
• Made updateProps always set but with undefined value, avoiding break changes and making the compiler happy.
• Hide updateProps and children from wrap options.

💡 Motivation and Context

Fixes: #4728

💚 How did you test it?

Unit test, Sample app

📝 Checklist

• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
• I updated the docs if needed.
• I updated the wizard if needed.
• All tests passing
• No breaking changes

🔮 Next steps

#skip-changelog.

[antonis]

The code changes and the tests LGMT and aligned with the previous discussion #4568 (comment) 🚀

[krystofwoldrich]

There is already wrap.test.tsx in the tests. We should add the new tests there.

Since it's TSX, we can use the JSX syntax, which will make the test more readable.

[krystofwoldrich]

As seen on the above code, we have a tiny margin that this could break (same behavior could happen before this PR) where we set props before triggering shouldComponentUpdate and then set it as undefined and call shouldComponentUpdate, could make it go inside the if condition and break Object.keys since updateProps is undefined.

That could be addressed on a follow up issue since this issue wasn't introduced by this PR.

Let's fix this at once. Looking at the JS implementation, we should pass the appProps to the profiler so it can create spans for the root updates. (js impl)

[krystofwoldrich]

I noticed a few things that should be addressed before merging.

[lucas-zimerman]

I noticed a few things that should be addressed before merging.

I can't change ReactNativeProfiler to make updateProps optional, since it requires me to make a large rewrite or alter Profiler from @sentry/react to make it optional.

As a way to avoid a big change, I added a flag to remove this parameter when it is included by our wrap function.
Let me know if you have any opinion in regard to it

[krystofwoldrich]

I thought we would keep the updateProps: {}? I think just removing the updateProps from the wrap type and here ensuring they will always be {} is enough. I would not delete them in the ReactNativeProfiler class.