Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Oct 22, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

Based on: #4472

📜 Description

⚠️ TODO fix conflicts in packages/core/ios/RNSentry.mm and move the newly added functionality to packages/core/ios/RNSentryStart.m following the refactoring in #4472

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@lucas-zimerman
Copy link
Collaborator

due to the age of this PR, wouldn't it be better to start from a fresh branch and migrate the required changes for it?

@antonis
Copy link
Contributor Author

antonis commented Oct 31, 2025

due to the age of this PR, wouldn't it be better to start from a fresh branch and migrate the required changes for it?

Yes, I'm trying that approach 😓 A lot of things have move around with v7 and there are changes in native code too that make a merge difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants