fix(types): Object.freeze type pollution from @sentry-internal/replay
#5408
+140
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@sentry review |
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ff5a06a+dirty | 405.97 ms | 439.24 ms | 33.27 ms |
| 526494a+dirty | 422.80 ms | 438.90 ms | 16.10 ms |
| 8490686+dirty | 365.59 ms | 400.24 ms | 34.65 ms |
| a0b15d6 | 423.06 ms | 437.77 ms | 14.71 ms |
| 1e7a472+dirty | 348.80 ms | 362.55 ms | 13.75 ms |
| 95aaf8a | 437.89 ms | 419.45 ms | -18.44 ms |
| b80b14f+dirty | 505.06 ms | 534.32 ms | 29.26 ms |
| 3401245+dirty | 503.02 ms | 516.86 ms | 13.84 ms |
| 955f2eb+dirty | 422.74 ms | 410.19 ms | -12.55 ms |
| b3b5b0d | 399.82 ms | 419.20 ms | 19.38 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ff5a06a+dirty | 43.75 MiB | 48.05 MiB | 4.29 MiB |
| 526494a+dirty | 43.75 MiB | 47.99 MiB | 4.24 MiB |
| 8490686+dirty | 17.75 MiB | 19.70 MiB | 1.96 MiB |
| a0b15d6 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 1e7a472+dirty | 17.75 MiB | 19.70 MiB | 1.96 MiB |
| 95aaf8a | 17.75 MiB | 19.68 MiB | 1.93 MiB |
| b80b14f+dirty | 43.75 MiB | 48.04 MiB | 4.29 MiB |
| 3401245+dirty | 43.75 MiB | 48.02 MiB | 4.27 MiB |
| 955f2eb+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| b3b5b0d | 17.75 MiB | 19.68 MiB | 1.94 MiB |
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ff5a06a+dirty | 438.29 ms | 476.00 ms | 37.71 ms |
| 526494a+dirty | 361.10 ms | 410.84 ms | 49.74 ms |
| 49ef936+dirty | 333.72 ms | 387.51 ms | 53.79 ms |
| 2b89ce9+dirty | 372.22 ms | 417.06 ms | 44.84 ms |
| 5ee3314+dirty | 358.69 ms | 394.00 ms | 35.31 ms |
| b80b14f+dirty | 320.33 ms | 376.06 ms | 55.73 ms |
| 3401245+dirty | 443.51 ms | 487.60 ms | 44.09 ms |
| 95aaf8a+dirty | 342.82 ms | 393.75 ms | 50.93 ms |
| 1853710+dirty | 360.67 ms | 396.28 ms | 35.61 ms |
| 083f560+dirty | 383.96 ms | 417.76 ms | 33.80 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ff5a06a+dirty | 43.94 MiB | 48.87 MiB | 4.93 MiB |
| 526494a+dirty | 43.94 MiB | 48.82 MiB | 4.88 MiB |
| 49ef936+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 2b89ce9+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 5ee3314+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| b80b14f+dirty | 43.94 MiB | 48.87 MiB | 4.93 MiB |
| 3401245+dirty | 43.94 MiB | 48.85 MiB | 4.91 MiB |
| 95aaf8a+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 1853710+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 083f560+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 64cd15c+dirty | 1213.50 ms | 1223.54 ms | 10.04 ms |
| 1e7a472+dirty | 1237.44 ms | 1231.14 ms | -6.29 ms |
| 955f2eb+dirty | 1225.78 ms | 1239.27 ms | 13.49 ms |
| d081295+dirty | 1205.24 ms | 1207.52 ms | 2.28 ms |
| 05bef0e+dirty | 1223.31 ms | 1225.55 ms | 2.24 ms |
| 46e3d54+dirty | 1213.17 ms | 1216.33 ms | 3.17 ms |
| d751a5d+dirty | 1212.22 ms | 1217.94 ms | 5.71 ms |
| a0b15d6+dirty | 1213.79 ms | 1210.45 ms | -3.34 ms |
| ec14be7+dirty | 1229.62 ms | 1230.53 ms | 0.91 ms |
| 20daa0a+dirty | 1227.71 ms | 1233.72 ms | 6.01 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 64cd15c+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 1e7a472+dirty | 3.19 MiB | 4.56 MiB | 1.38 MiB |
| 955f2eb+dirty | 3.19 MiB | 4.55 MiB | 1.36 MiB |
| d081295+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| 05bef0e+dirty | 3.19 MiB | 4.56 MiB | 1.37 MiB |
| 46e3d54+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| d751a5d+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
| a0b15d6+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| ec14be7+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
| 20daa0a+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 64cd15c+dirty | 1216.31 ms | 1214.04 ms | -2.26 ms |
| 1e7a472+dirty | 1223.39 ms | 1232.12 ms | 8.73 ms |
| 955f2eb+dirty | 1235.06 ms | 1253.88 ms | 18.81 ms |
| d081295+dirty | 1214.40 ms | 1211.27 ms | -3.13 ms |
| 05bef0e+dirty | 1221.02 ms | 1237.04 ms | 16.02 ms |
| 46e3d54+dirty | 1216.40 ms | 1210.47 ms | -5.93 ms |
| d751a5d+dirty | 1215.57 ms | 1220.56 ms | 4.99 ms |
| a0b15d6+dirty | 1220.18 ms | 1223.18 ms | 3.00 ms |
| ec14be7+dirty | 1234.64 ms | 1245.54 ms | 10.90 ms |
| 20daa0a+dirty | 1233.12 ms | 1233.35 ms | 0.22 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 64cd15c+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 1e7a472+dirty | 2.63 MiB | 4.00 MiB | 1.36 MiB |
| 955f2eb+dirty | 2.63 MiB | 3.98 MiB | 1.35 MiB |
| d081295+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| 05bef0e+dirty | 2.63 MiB | 3.99 MiB | 1.36 MiB |
| 46e3d54+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| d751a5d+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
| a0b15d6+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| ec14be7+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
| 20daa0a+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
Collaborator
|
That's an interresting fix! could it also affect user code? or limited to Sentry? |
lucas-zimerman
approved these changes
Nov 26, 2025
Contributor
Author
Good point @lucas-zimerman 👍 The global declaration should also cover user code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Fixes
Object.freezetype pollution from@sentry-internal/replay. An ideal solution would probably involve changing the exports in the JS SDK but I'm not sure if this will lead to other breakages.💡 Motivation and Context
Fixes #5407
💚 How did you test it?
CI, Manual
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps