Skip to content

Add W3C traceparent headers to distributed tracing#2310

Closed
sl0thentr0py wants to merge 1 commit intomasterfrom
neel/w3c-traceparent
Closed

Add W3C traceparent headers to distributed tracing#2310
sl0thentr0py wants to merge 1 commit intomasterfrom
neel/w3c-traceparent

Conversation

@sl0thentr0py
Copy link
Copy Markdown
Member

@sl0thentr0py sl0thentr0py commented May 13, 2024

closes #2276

@sl0thentr0py sl0thentr0py changed the title w3c traceparent Add W3C traceparent headers to distributed tracing May 13, 2024
# @param traceparent [String] the traceparent header value from the previous transaction.
# @return [Array, nil]
def self.extract_w3c_traceparent(traceparent)
match = W3C_TRACEPARENT_REGEX.match(traceparent)

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data

This [regular expression](1) that depends on a [library input](2) may run slow on strings with many repetitions of '\t'.
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2024

Codecov Report

❌ Patch coverage is 76.47059% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.61%. Comparing base (186b1e4) to head (9974c9f).
⚠️ Report is 260 commits behind head on master.

Files with missing lines Patch % Lines
sentry-ruby/lib/sentry/propagation_context.rb 61.90% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2310      +/-   ##
==========================================
- Coverage   98.67%   98.61%   -0.06%     
==========================================
  Files         205      205              
  Lines       13329    13359      +30     
==========================================
+ Hits        13152    13174      +22     
- Misses        177      185       +8     
Components Coverage Δ
sentry-ruby 98.95% <76.47%> (-0.08%) ⬇️
sentry-rails 97.37% <ø> (ø)
sentry-sidekiq 96.98% <ø> (ø)
sentry-resque 97.08% <ø> (ø)
sentry-delayed_job 98.91% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry-ruby.rb 96.66% <100.00%> (+0.06%) ⬆️
sentry-ruby/lib/sentry/hub.rb 99.40% <100.00%> (+0.01%) ⬆️
sentry-ruby/lib/sentry/span.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry_spec.rb 99.85% <ø> (ø)
sentry-ruby/lib/sentry/propagation_context.rb 87.14% <61.90%> (-12.86%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sl0thentr0py
Copy link
Copy Markdown
Member Author

will reopen as necessary

@sl0thentr0py sl0thentr0py deleted the neel/w3c-traceparent branch September 26, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

W3C Trace Context support

2 participants