Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Sentry.Unity.Android/BreadcrumbExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public static AndroidJavaObject ToJavaSentryLevel(this BreadcrumbLevel level)
using var javaSentryLevel = new AndroidJavaClass("io.sentry.SentryLevel");
return level switch
{
BreadcrumbLevel.Critical => javaSentryLevel.GetStatic<AndroidJavaObject>("FATAL"),
BreadcrumbLevel.Fatal => javaSentryLevel.GetStatic<AndroidJavaObject>("FATAL"),
BreadcrumbLevel.Error => javaSentryLevel.GetStatic<AndroidJavaObject>("ERROR"),
BreadcrumbLevel.Warning => javaSentryLevel.GetStatic<AndroidJavaObject>("WARNING"),
BreadcrumbLevel.Debug => javaSentryLevel.GetStatic<AndroidJavaObject>("DEBUG"),
Expand Down
2 changes: 1 addition & 1 deletion src/Sentry.Unity.iOS/NativeScopeObserver.cs
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ internal static int GetBreadcrumbLevel(BreadcrumbLevel breadcrumbLevel) =>
BreadcrumbLevel.Info => 2,
BreadcrumbLevel.Warning => 3,
BreadcrumbLevel.Error => 4,
BreadcrumbLevel.Critical => 5,
BreadcrumbLevel.Fatal => 5,
_ => 0
};
}
21 changes: 0 additions & 21 deletions src/Sentry.Unity/SentrySdk.Dotnet.cs
Original file line number Diff line number Diff line change
Expand Up @@ -324,27 +324,6 @@ public static void CaptureFeedback(string message, string? contactEmail = null,
=> Sentry.SentrySdk.CaptureFeedback(new SentryFeedback(message, contactEmail, name, replayId, url, associatedEventId),
scope, hint);

/// <summary>
/// Captures a user feedback.
/// </summary>
/// <param name="userFeedback">The user feedback to send to Sentry.</param>
[DebuggerStepThrough]
[Obsolete("Use CaptureFeedback instead.")]
public static void CaptureUserFeedback(UserFeedback userFeedback)
=> Sentry.SentrySdk.CaptureUserFeedback(userFeedback);

/// <summary>
/// Captures a user feedback.
/// </summary>
/// <param name="eventId">The event Id.</param>
/// <param name="email">The user email.</param>
/// <param name="comments">The user comments.</param>
/// <param name="name">The optional username.</param>
[DebuggerStepThrough]
[Obsolete("Use CaptureFeedback instead.")]
public static void CaptureUserFeedback(SentryId eventId, string email, string comments, string? name = null)
=> Sentry.SentrySdk.CaptureUserFeedback(new UserFeedback(eventId, name, email, comments));

/// <summary>
/// Captures a transaction.
/// </summary>
Expand Down
2 changes: 1 addition & 1 deletion src/sentry-dotnet
Submodule sentry-dotnet updated 292 files
8 changes: 2 additions & 6 deletions test/Sentry.Unity.Tests/Stubs/TestHub.cs
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,6 @@ public void CaptureFeedback(SentryFeedback feedback, Scope? scope = null, Sentry
throw new NotImplementedException();
}

[Obsolete("Obsolete")]
public void CaptureUserFeedback(UserFeedback userFeedback)
{
throw new NotImplementedException();
}

public void CaptureTransaction(SentryTransaction transaction) =>
_capturedTransactions.Add(transaction);

Expand Down Expand Up @@ -161,6 +155,8 @@ public TransactionContext ContinueTrace(SentryTraceHeader? traceHeader, BaggageH
throw new NotImplementedException();
}

public bool IsSessionActive => false;

public void StartSession()
{
// TODO: test sessions
Expand Down
2 changes: 1 addition & 1 deletion test/Sentry.Unity.iOS.Tests/NativeScopeObserverTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public void GetTimestamp_ReturnStringConformsToISO8601()
[TestCase(BreadcrumbLevel.Info, 2)]
[TestCase(BreadcrumbLevel.Warning, 3)]
[TestCase(BreadcrumbLevel.Error, 4)]
[TestCase(BreadcrumbLevel.Critical, 5)]
[TestCase(BreadcrumbLevel.Fatal, 5)]
public void GetBreadcrumbLevel_TestCases(BreadcrumbLevel level, int expectedNativeLevel)
{
var actualLevel = NativeScopeObserver.GetBreadcrumbLevel(level);
Expand Down