chore: CI Improvements #2422
chore: CI Improvements #2422
Conversation
| if [[ $unityPrefix -ge 2021 ]]; then | ||
| $suexec $container chmod -R 755 /opt/unity/Editor/Data/UnityReferenceAssemblies/ | ||
| fi | ||
| $suexec $container chmod -R 755 /opt/unity/Editor/Data/UnityReferenceAssemblies/ |
There was a problem hiding this comment.
This was failing with
./scripts/ci-docker.sh: line 53: [[: 6000.0: syntax error: invalid arithmetic operator (error token is ".0")
and we're running on 2021+ only anyway.
| run: | | ||
| docker exec unity dotnet msbuild /t:UnityConfigureSentryOptions /p:TestDsn= /p:Configuration=Release /p:OutDir=other src/Sentry.Unity | ||
| docker exec unity dotnet msbuild /t:UnityPlayModeTest /p:Configuration=Release /p:OutDir=other test/Sentry.Unity.Tests | ||
| run: docker exec unity dotnet msbuild /t:UnityPlayModeTest /p:Configuration=Release /p:OutDir=other test/Sentry.Unity.Tests |
There was a problem hiding this comment.
Running it twice was a leftover from a time where we had to manually set/replace the TestDsn. That's no longer needed.
| DEBIAN_FRONTEND: noninteractive | ||
|
|
||
| - name: Install .NET SDK | ||
| if: ${{ steps.cache.outputs.cache-hit != 'true' }} |
There was a problem hiding this comment.
Added missing skips if the cache was hit.
| env: | ||
| UNITY_SCRIPT_ARG: unity${{ env.UNITY_VERSION }} | ||
|
|
||
| - run: echo "::add-mask::$LICENSE_SERVER_URL" |
There was a problem hiding this comment.
The masking does nothing
Can't add secret mask for empty string in ##[add-mask] command.
| - name: Restore .NET Workload | ||
| run: dotnet workload restore | ||
|
|
||
| - name: Install Android dotnet workflow |
There was a problem hiding this comment.
dotnet workload restore already does that for us
| env: | ||
| LICENSE_SERVER_URL: ${{ secrets.LICENSE_SERVER_URL }} | ||
|
|
||
| - name: Restore Unity Packages |
There was a problem hiding this comment.
I don't even remember why we were trying to cache the packages only. But it doesn't work in any case:
Cache not found for input keys
We're just caching the full Library like in the rest of CI instead. This lets us skip the full on creation of the assetdatabase with every single run.
These improvements include but are not limited to
#skip-changelog