feat(perforce): Add backend support for Perforce integration

src/sentry/integrations/perforce/client.py

@@ -2,16 +2,22 @@
 
 import logging
 from collections.abc import Sequence
+from datetime import datetime, timezone
 from typing import Any
 
+from P4 import P4, P4Exception
+
 from sentry.integrations.source_code_management.commit_context import (
     CommitContextClient,
+    CommitInfo,
     FileBlameInfo,
     SourceLineInfo,
 )
 from sentry.integrations.source_code_management.repository import RepositoryClient
 from sentry.models.pullrequest import PullRequest, PullRequestComment
 from sentry.models.repository import Repository
+from sentry.shared_integrations.exceptions import ApiError
+from sentry.utils import metrics
 
 logger = logging.getLogger(__name__)
 
@@ -38,14 +44,54 @@ def __init__(
         self.password = password
         self.client_name = client
         self.base_url = f"p4://{self.host}:{self.port}"
+        self.P4 = P4
+        self.P4Exception = P4Exception
 
     def _connect(self):
         """Create and connect a P4 instance."""
-        pass
+        is_ticket_auth = bool(self.ticket)
+
+        p4 = self.P4()
+
+        if is_ticket_auth:
+            # Ticket authentication: P4Python auto-extracts host/port/user from ticket
+            # Just set the ticket as password and P4 will handle the rest
+            p4.password = self.ticket
+        else:
+            # Password authentication: set host/port/user explicitly
+            p4.port = f"{self.host}:{self.port}"
+            p4.user = self.user
+
+            if self.password:
+                p4.password = self.password
+
+        if self.client_name:
+            p4.client = self.client_name
+
+        p4.exception_level = 1  # Only errors raise exceptions
+
+        try:
+            p4.connect()
+
+            # Authenticate with the server if password is provided (not ticket)
+            if self.password and not is_ticket_auth:
+                try:
+                    p4.run_login()
+                except self.P4Exception as login_error:
+                    p4.disconnect()
+                    raise ApiError(f"Failed to authenticate with Perforce: {login_error}")
+
+            return p4
+        except self.P4Exception as e:
+            raise ApiError(f"Failed to connect to Perforce: {e}")
 
     def _disconnect(self, p4):
         """Disconnect P4 instance."""
-        pass
+        try:
+            if p4.connected():
+                p4.disconnect()
+        except Exception:
+            pass
 
     def check_file(self, repo: Repository, path: str, version: str | None) -> object | None:
         """
@@ -59,7 +105,19 @@ def check_file(self, repo: Repository, path: str, version: str | None) -> object
         Returns:
             File info dict if exists, None otherwise
         """
-        return None
+        p4 = self._connect()
+        try:
+            depot_path = self._build_depot_path(repo, path)
+            result = p4.run("files", depot_path)
+
+            if result and len(result) > 0:
+                return result[0]
+            return None
+
+        except self.P4Exception:
+            return None
+        finally:
+            self._disconnect(p4)
 
     def get_file(
         self, repo: Repository, path: str, ref: str | None, codeowners: bool = False
@@ -76,7 +134,22 @@ def get_file(
         Returns:
             File contents as string
         """
-        return ""
+        p4 = self._connect()
+        try:
+            depot_path = self._build_depot_path(repo, path)
+            result = p4.run("print", "-q", depot_path)
+
+            if result and len(result) > 1:
+                # First element is file info, second is content
+                return result[1]
+
+            raise ApiError(f"File not found: {depot_path}")
+
+        except self.P4Exception as e:
+            logger.exception("perforce.get_file_failed", extra={"path": path})
+            raise ApiError(f"Failed to get file: {e}")
+        finally:
+            self._disconnect(p4)
 
     def _build_depot_path(self, repo: Repository, path: str, ref: str | None = None) -> str:
         """
@@ -90,7 +163,21 @@ def _build_depot_path(self, repo: Repository, path: str, ref: str | None = None)
         Returns:
             Full depot path with @revision preserved if present
         """
-        return ""
+        depot_root = repo.config.get("depot_path", repo.name).rstrip("/")
+
+        # Ensure path doesn't start with /
+        path = path.lstrip("/")
+
+        # If path contains @revision, preserve it (e.g., "file.cpp@42")
+        # If ref is provided and path doesn't have @revision, append it
+        full_path = f"{depot_root}/{path}"
+
+        # If ref is provided and path doesn't already have @revision, append it
+        # Skip "master" as it's a Git concept and not valid in Perforce
+        if ref and "@" not in path and ref != "master":
+            full_path = f"{full_path}@{ref}"
+
+        return full_path
 
     def get_blame(
         self, repo: Repository, path: str, ref: str | None = None, lineno: int | None = None
@@ -115,7 +202,50 @@ def get_blame(
             - date: date of change
             - description: changelist description
         """
-        return []
+        p4 = self._connect()
+        try:
+            depot_path = self._build_depot_path(repo, path, ref)
+
+            # Use 'p4 filelog' to get the most recent changelist for this file
+            # This is much faster than 'p4 annotate'
+            # If depot_path includes @revision, filelog will show history up to that revision
+            filelog = p4.run("filelog", "-m1", depot_path)
+
+            if not filelog or len(filelog) == 0:
+                return []
+
+            # Get the most recent changelist number
+            # filelog returns a list of revisions, we want the first one
+            revisions = filelog[0].get("rev", [])
+            if not revisions or len(revisions) == 0:
+                return []
+
+            # Get the changelist number from the first revision
+            changelist = revisions[0].get("change")
+            if not changelist:
+                return []
+
+            # Get detailed changelist information using 'p4 describe'
+            # -s flag means "short" - don't include diffs, just metadata
+            change_info = p4.run("describe", "-s", changelist)
+
+            if not change_info:
+                return []
+
+            change_data = change_info[0]
+            return [
+                {
+                    "changelist": str(changelist),
+                    "user": change_data.get("user", "unknown"),
+                    "date": change_data.get("time", ""),
+                    "description": change_data.get("desc", ""),
+                }
+            ]
+
+        except self.P4Exception:
+            return []
+        finally:
+            self._disconnect(p4)
 
     def get_depot_info(self) -> dict[str, Any]:
         """
@@ -124,7 +254,17 @@ def get_depot_info(self) -> dict[str, Any]:
         Returns:
             Server info dictionary
         """
-        return {}
+        p4 = self._connect()
+        try:
+            info = p4.run("info")[0]
+            return {
+                "server_address": info.get("serverAddress"),
+                "server_version": info.get("serverVersion"),
+                "user": info.get("userName"),
+                "client": info.get("clientName"),
+            }
+        finally:
+            self._disconnect(p4)
 
     def get_depots(self) -> list[dict[str, Any]]:
         """
@@ -133,7 +273,19 @@ def get_depots(self) -> list[dict[str, Any]]:
         Returns:
             List of depot info dictionaries
         """
-        return []
+        p4 = self._connect()
+        try:
+            depots = p4.run("depots")
+            return [
+                {
+                    "name": depot.get("name"),
+                    "type": depot.get("type"),
+                    "description": depot.get("desc", ""),
+                }
+                for depot in depots
+            ]
+        finally:
+            self._disconnect(p4)
 
     def get_changes(
         self, depot_path: str, max_changes: int = 20, start_cl: str | None = None
@@ -149,7 +301,31 @@ def get_changes(
         Returns:
             List of changelist dictionaries
         """
-        return []
+        p4 = self._connect()
+        try:
+            args = ["-m", str(max_changes), "-l"]
+
+            if start_cl:
+                args.extend(["-e", start_cl])
+
+            args.append(depot_path)
+
+            changes = p4.run("changes", *args)
+
+            return [
+                {
+                    "change": change.get("change"),
+                    "user": change.get("user"),
+                    "client": change.get("client"),
+                    "time": change.get("time"),
+                    "desc": change.get("desc"),
+                }
+                for change in changes
+            ]
+        finally:
+            self._disconnect(p4)
+
+    # CommitContextClient methods (stubbed for now)
 
     def get_blame_for_files(
         self, files: Sequence[SourceLineInfo], extra: dict[str, Any]
@@ -165,7 +341,85 @@ def get_blame_for_files(
 
         Returns a list of FileBlameInfo objects containing commit details for each file.
         """
-        return []
+        metrics.incr("integrations.perforce.get_blame_for_files")
+        blames = []
+        p4 = self._connect()
+
+        try:
+            for file in files:
+                try:
+                    # Build depot path for the file (includes stream if specified)
+                    # file.ref contains the revision/changelist if available
+                    depot_path = self._build_depot_path(file.repo, file.path, file.ref)
+
+                    # Use faster p4 filelog approach to get most recent changelist
+                    # This is much faster than p4 annotate
+                    filelog = p4.run("filelog", "-m1", depot_path)
+
+                    changelist = None
+                    if filelog and len(filelog) > 0:
+                        # The 'change' field contains the changelist numbers (as a list of strings)
+                        changelists = filelog[0].get("change", [])
+                        if changelists and len(changelists) > 0:
+                            # Get the first (most recent) changelist number
+                            changelist = changelists[0]
+
+                    # If we found a changelist, get detailed commit info
+                    if changelist:
+                        try:
+                            change_info = p4.run("describe", "-s", changelist)
+                            if change_info and len(change_info) > 0:
+                                change = change_info[0]
+                                username = change.get("user", "unknown")
+                                # Perforce doesn't provide email by default, so we generate a fallback
+                                email = change.get("email") or f"{username}@perforce.local"
+                                commit = CommitInfo(
+                                    commitId=changelist,
+                                    committedDate=datetime.fromtimestamp(
+                                        int(change.get("time", 0)), tz=timezone.utc
+                                    ),
+                                    commitMessage=change.get("desc", "").strip(),
+                                    commitAuthorName=username,
+                                    commitAuthorEmail=email,
+                                )
+
+                                blame_info = FileBlameInfo(
+                                    lineno=file.lineno,
+                                    path=file.path,
+                                    ref=file.ref,
+                                    repo=file.repo,
+                                    code_mapping=file.code_mapping,
+                                    commit=commit,
+                                )
+                                blames.append(blame_info)
+                        except self.P4Exception as e:
+                            logger.warning(
+                                "perforce.client.get_blame_for_files.describe_error",
+                                extra={
+                                    **extra,
+                                    "changelist": changelist,
+                                    "error": str(e),
+                                    "repo_name": file.repo.name,
+                                    "file_path": file.path,
+                                },
+                            )
+                except self.P4Exception as e:
+                    # Log but don't fail for individual file errors
+                    logger.warning(
+                        "perforce.client.get_blame_for_files.annotate_error",
+                        extra={
+                            **extra,
+                            "error": str(e),
+                            "repo_name": file.repo.name,
+                            "file_path": file.path,
+                            "file_lineno": file.lineno,
+                        },
+                    )
+                    continue
+
+            return blames
+        finally:
+            self._disconnect(p4)
 
     def create_comment(self, repo: str, issue_id: str, data: dict[str, Any]) -> Any:
         """Create comment. Not applicable for Perforce."""