Skip to content

chore(events): Clean up preprocess option (1/3) #103192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(events): Clean up preprocess option (1/3) #103192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/sentry/utils/snuba.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
from snuba_sdk.legacy import json_to_snql
from snuba_sdk.query import SelectableExpression

from sentry import options
from sentry.api.helpers.error_upsampling import (
UPSAMPLED_ERROR_AGGREGATION,
are_any_projects_error_upsampled,
Expand Down Expand Up @@ -928,7 +927,7 @@ def __init__(
# account for merges, here we expand queries to include all group IDs that have
# been merged together.

if options.get("snuba.preprocess-group-redirects") and self.dataset in {
if self.dataset in {
Dataset.Events,
Dataset.IssuePlatform,
}:
Expand Down
3 changes: 0 additions & 3 deletions tests/sentry/utils/test_snuba.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
from urllib3.exceptions import HTTPError, ReadTimeoutError
from urllib3.response import HTTPResponse

from sentry import options
from sentry.models.groupredirect import GroupRedirect
from sentry.models.grouprelease import GroupRelease
from sentry.models.project import Project
Expand Down Expand Up @@ -326,8 +325,6 @@ def test_preprocess_group_redirects(self) -> None:
previous_group_id=g3.id,
)

options.set("snuba.preprocess-group-redirects", True)

params = SnubaQueryParams(dataset=Dataset.Events, filter_keys={"group_id": {g1.id}})
assert params.conditions[0] == ["group_id", "IN", {g1.id, g2.id, g3.id}]

Expand Down
Loading