Skip to content

chore (user feedback): reverse activity order + scroll to bottom on new comments #103402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

chore (user feedback): reverse activity order + scroll to bottom on new comments #103402

wants to merge 2 commits into from
+21 −22

Conversation

@mtopo27
Copy link
Contributor

@mtopo27 mtopo27 commented Nov 14, 2025 •
edited
Loading

Screen.Recording.2025-11-17.at.11.17.02.AM.mov

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 14, 2025
@codecov
Copy link

codecov bot commented Nov 17, 2025

❌ 28 Tests Failed:

Tests completed Failed Passed Skipped
12592 28 12564 10
View the top 3 failed test(s) by shortest run time 
GroupActivity resolved in commit with no releases
Stack Traces | 0.031s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Foo Bar marked this issue as resolved in komal-commit
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:281:22)
GroupActivity regression renders a deleted attachment activity
Stack Traces | 0.034s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  deleted an attachment
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:803:24)
GroupActivity renders escalating with forecast and singular event
Stack Traces | 0.035s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Sentry flagged this issue as escalating because over 1 event happened in an hour
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:490:22)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:549:9)
    at processTimers (node:internal/timers:523:7)
GroupActivity regression renders a set priority activity for ongoing issues
Stack Traces | 0.037s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Sentry updated the priority value of this issue to be low after it was marked as ongoing
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:785:24)
GroupActivity renders escalating since until date passed
Stack Traces | 0.037s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Sentry flagged this issue as escalating because Oct 30, 2018 12:00 AM passed
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:606:22)
GroupActivity renders issue unresvoled via jira
Stack Traces | 0.037s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Sentry marked this issue as unresolved via Jira
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:512:22)
GroupActivity renders resolved in next release with semver information
Stack Traces | 0.037s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Foo Bar marked this issue as resolved in releases greater than 1.0.0 (semver)
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:662:22)
GroupActivity renders archived forever
Stack Traces | 0.038s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Foo Bar archived this issue forever
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:624:22)
GroupActivity regression renders regression with version
Stack Traces | 0.042s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Sentry marked this issue as a regression in 1.0.0
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:697:24)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:549:9)
    at processTimers (node:internal/timers:523:7)
GroupActivity renders issue resolved via jira
Stack Traces | 0.042s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Sentry marked this issue as resolved via Jira
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:532:22)
GroupActivity regression renders regression with non-semver description
Stack Traces | 0.043s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Sentry marked this issue as a regression in abc1
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:742:24)
GroupActivity regression renders basic regression
Stack Traces | 0.044s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Sentry marked this issue as a regression
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:680:24)
GroupActivity regression renders a set priority activity for escalating issues
Stack Traces | 0.045s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Sentry updated the priority value of this issue to be high after it escalated
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:765:24)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:549:9)
    at processTimers (node:internal/timers:523:7)
GroupActivity renders escalating since it happened x times in time window
Stack Traces | 0.045s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Sentry flagged this issue as escalating because 400 events happened in 1 minute
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:555:22)
GroupActivity renders resolved in release with semver information
Stack Traces | 0.045s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Foo Bar marked this issue as resolved in 1.0.0 (semver)
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:642:22)
GroupActivity regression renders regression with semver description
Stack Traces | 0.046s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Sentry marked this issue as a regression in 2.0.0
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:718:24)
GroupActivity renders archived until escalating
Stack Traces | 0.047s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Foo Bar archived this issue until it escalates
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:440:22)
GroupActivity does not render undefined when integration is not recognized
Stack Traces | 0.048s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  /Sentry assigned this issue to [email protected]/
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:254:22)
GroupActivity renders escalating with forecast and plural events
Stack Traces | 0.048s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Sentry flagged this issue as escalating because over 400 events happened in an hour
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:467:31)
GroupActivity renders escalating since x users were affected in time window
Stack Traces | 0.05s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Sentry flagged this issue as escalating because 1 user was affected in 1 minute
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:580:22)
GroupActivity resolved in commit with one release
Stack Traces | 0.05s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Foo Bar marked this issue as resolved in komal-commit This commit was released in random
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:313:22)
GroupActivity renders an assigned via slack activity
Stack Traces | 0.051s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  /Mark assigned this issue to [email protected]/
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:204:18)
GroupActivity resolved in commit with multiple releases
Stack Traces | 0.053s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Foo Bar marked this issue as resolved in komal-commit This commit was released in oldest-release and 3 others
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:360:22)
GroupActivity renders a pr activity
Stack Traces | 0.057s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Test User has created a PR for this issue:
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:132:68)
GroupActivity renders an assigned via suspect commit activity
Stack Traces | 0.057s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  /Sentry auto-assigned this issue to [email protected]/
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:227:22)
GroupActivity renders a assigned to self activity
Stack Traces | 0.058s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  /Mark assigned this issue to themselves/
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:155:68)
GroupActivity renders an assigned via codeowners activity
Stack Traces | 0.06s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  /Sentry auto-assigned this issue to [email protected]/
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:179:68)
GroupActivity requests assignees that are not in the team store
Stack Traces | 0.078s run time 
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  /Sentry assigned this issue to #team-slug/
Received:
  FBWritePreview Markdown supportedPost Comment
    at Object.toHaveTextContent (.../views/issueDetails/groupActivity.spec.tsx:391:59)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@mtopo27
Copy link
Contributor Author

mtopo27 commented Nov 17, 2025

tests are failing b/c <ActivitySection> is used in more than just feedback. If we're changing the order from earliest -> latest, it makes most sense to have the input on the bottom, which is the change in ActivitySection (people read the context of the thread then comment).

Not going to address test failures atm b/c changing the position of the input is no longer isolated to feedback page, will wait until there's some level of consensus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mtopo27