Skip to content

fix(code-review): Look up code review beta orgs dynamically #105603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suejung-sentry merged 2 commits into from
Jan 2, 2026
Merged

fix(code-review): Look up code review beta orgs dynamically #105603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57d7e3c
fix(code-review): Look up code review beta orgs dynamically
suejung-sentry Jan 2, 2026
a6d0bd7
fix tests
suejung-sentry Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/sentry/seer/code_review/permissions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,8 @@ def has_code_review_enabled(organization: Organization) -> bool:
if not pr_review_test_generation_enabled:
return False

return features.has("organizations:code-review-beta", organization)
# TODO: Remove the pr_review_test_generation_enabled check after the beta list is frozen
return (
features.has("organizations:code-review-beta", organization)
or pr_review_test_generation_enabled
)
19 changes: 16 additions & 3 deletions tests/sentry/seer/code_review/test_webhooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,16 +181,16 @@ def test_check_run_without_integration_returns_204(self) -> None:

@patch("sentry.seer.code_review.webhooks.task.process_github_webhook_event")
@with_feature({"organizations:gen-ai-features"})
def test_check_run_skips_when_code_review_beta_flag_disabled(
def test_check_run_runs_when_code_review_beta_flag_disabled_but_pr_review_test_generation_enabled(
self, mock_task: MagicMock
) -> None:
"""Test that task is not enqueued when code-review-beta flag is off."""
"""Test that task is enqueued when code-review-beta flag is off but pr_review_test_generation is enabled."""
self._enable_code_review()
self._send_webhook_event(
GithubWebhookType.CHECK_RUN,
CHECK_RUN_REREQUESTED_ACTION_EVENT_EXAMPLE,
)
mock_task.delay.assert_not_called()
mock_task.delay.assert_called_once()

@patch("sentry.seer.code_review.utils.make_seer_request")
@with_feature(CODE_REVIEW_FEATURES)
Expand Down Expand Up @@ -733,6 +733,19 @@ def test_skips_when_no_review_command(self, mock_schedule: MagicMock) -> None:
self._send_issue_comment_event(event)
mock_schedule.assert_not_called()

@patch("sentry.seer.code_review.webhooks.task.schedule_task")
@with_feature({"organizations:gen-ai-features"})
def test_runs_when_code_review_beta_flag_disabled_but_pr_review_test_generation_enabled(
self, mock_schedule: MagicMock
) -> None:
with self.options(
{"organizations:code-review-beta": False, "github.webhook.issue-comment": False}
):
self.organization.update_option("sentry:enable_pr_review_test_generation", True)
event = self._build_issue_comment_event(f"Please {SENTRY_REVIEW_COMMAND} this PR")
self._send_issue_comment_event(event)
mock_schedule.assert_called_once()

@patch("sentry.seer.code_review.webhooks.task.make_seer_request")
@patch("sentry.integrations.github.client.GitHubApiClient.create_comment_reaction")
@with_feature({"organizations:gen-ai-features", "organizations:code-review-beta"})
Expand Down
Loading