Skip to content

tests(code_review): Split tests by webhook type #105673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
armenzg merged 5 commits into from
Jan 6, 2026
Merged

tests(code_review): Split tests by webhook type #105673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
79793f5
tests(code_review): Split tests by webhook type
armenzg Jan 5, 2026
a5e4360
test(code_review): Split into multiple test modules
armenzg Jan 5, 2026
02d65d6
ref(tests): Add GitHubWebhookCodeReviewTestCase helper class
armenzg Jan 5, 2026
6a48edd
More changes
armenzg Jan 6, 2026
093dc5d
Fix improper imports
armenzg Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions src/sentry/testutils/helpers/github.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,13 @@

from __future__ import annotations

from collections.abc import Collection, Generator, Mapping
from contextlib import contextmanager
from datetime import datetime, timedelta
from typing import Any
from uuid import uuid4

import orjson
from django.http.response import HttpResponseBase

from sentry import options
Expand Down Expand Up @@ -131,3 +134,42 @@ def send_github_webhook_event(
content_type="application/json",
**headers,
)


class GitHubWebhookCodeReviewTestCase(GitHubWebhookTestCase):
Copy link
Member Author

@armenzg armenzg Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This contains the logic from the GitHubWebhookHerlper:

sentry/tests/sentry/seer/code_review/test_webhooks.py

Lines 47 to 57 in 41232a2

@contextmanager
def code_review_setup(
self, features: Collection[str] | Mapping[str, Any] = CODE_REVIEW_FEATURES
) -> Generator[None]:
"""Helper to set up code review test context."""
self.organization.update_option("sentry:enable_pr_review_test_generation", True)
with (
self.feature(features),
self.options({"github.webhook.issue-comment": False}),
):
yield

CODE_REVIEW_FEATURES = {"organizations:gen-ai-features", "organizations:code-review-beta"}

@contextmanager
def code_review_setup(
self,
features: Collection[str] | Mapping[str, Any] | None = None,
forward_to_overwatch: bool = False,
) -> Generator[None]:
"""Helper to set up code review test context."""
self.organization.update_option("sentry:enable_pr_review_test_generation", True)
features_to_enable = self.CODE_REVIEW_FEATURES if features is None else features
with (
self.feature(features_to_enable),
self.options({"github.webhook.issue-comment": forward_to_overwatch}),
):
yield

def _send_webhook_event(
self, github_event: GithubWebhookType, event_data: bytes | str
) -> HttpResponseBase:
"""Helper to send a GitHub webhook event."""
self.event_dict = (
orjson.loads(event_data) if isinstance(event_data, (bytes, str)) else event_data
)
repo_id = int(self.event_dict["repository"]["id"])

integration = self.create_github_integration()
self.create_repo(
project=self.project,
provider="integrations:github",
external_id=repo_id,
integration_id=integration.id,
)
response = self.send_github_webhook_event(github_event, event_data)
assert response.status_code == 204
return response
Loading
Loading