sidebar: cleanup organization dropdown#105689
Merged
Conversation
github-actions
bot
added
the
Scope: Frontend
JonasBa
commented
Jan 5, 2026
| }: OrganizationAvatarProps) { | ||
| if (!organization) { | ||
| // @TODO(jonasbadalic): Do we need a placeholder here? | ||
| Sentry.captureMessage('OrganizationAvatar: organization summary is undefined'); |
Member
Author
There was a problem hiding this comment.
Nothing screams if I remove the undefined type, but I don't trust the types here, so I would like to see some data first
TkDodo
reviewed
Jan 7, 2026
Comment on lines
3
to
4
| import type {OrganizationSummary} from 'sentry/types/organization'; | ||
| import {explodeSlug} from 'sentry/utils'; |
Collaborator
There was a problem hiding this comment.
we should try to no tie core components to sentry specific types / utils. Maybe this shouldn’t be in scraps ?
Member
Author
There was a problem hiding this comment.
It was moved here initially because it was part of the Scraps initial component set, but I agree that we should either move it out of scraps, or make it's interface not tied to the Sentry type
Member
Author
There was a problem hiding this comment.
I would keep it out of the scope of this PR though, it's going to be a larger change
TkDodo
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small reorg of the OrganizationDropdown selector so I can familiarize myself with the code.