fix(seer onboarding): remove on_command_phrase CR trigger from settings forms #105696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ryan953
reviewed
Jan 6, 2026
static/gsApp/views/seerAutomation/components/repoDetails/repoDetailsForm.tsx
Outdated
Show resolved
Hide resolved
ryan953
reviewed
Jan 6, 2026
static/gsApp/views/seerAutomation/components/repoDetails/repoDetailsForm.tsx
Outdated
Show resolved
Hide resolved
ryan953
reviewed
Jan 6, 2026
static/gsApp/views/seerAutomation/components/repoDetails/repoDetailsForm.tsx
Outdated
Show resolved
Hide resolved
ryan953
reviewed
Jan 6, 2026
static/gsApp/views/seerAutomation/components/repoDetails/repoDetailsForm.tsx
Outdated
Show resolved
Hide resolved
ryan953
reviewed
Jan 6, 2026
static/gsApp/views/seerAutomation/components/repoDetails/repoDetailsForm.tsx
Outdated
Show resolved
Hide resolved
srest2021
force-pushed
the
srest2021/ENG-6194-frontend
branch
from
2c8e733 to
ef9b293
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
static/gsApp/views/seerAutomation/components/repoDetails/repoDetailsForm.tsx
Show resolved
Hide resolved
static/gsApp/views/seerAutomation/components/repoDetails/repoDetailsForm.tsx
Outdated
Show resolved
Hide resolved
static/gsApp/views/seerAutomation/components/repoDetails/repoDetailsForm.tsx
Show resolved
Hide resolved
static/gsApp/views/seerAutomation/components/repoDetails/repoDetailsForm.tsx
Show resolved
Hide resolved
ryan953
approved these changes
Jan 6, 2026
srest2021
force-pushed
the
srest2021/ENG-6194-frontend
branch
from
8596074 to
ee1f6cd
Compare
srest2021
changed the title
srest2021
added a commit
that referenced
this pull request
Jan 9, 2026
…ettings and org options (#105978) relates to ENG-6194 depends on codecov/overwatch#622 (deployed) depends on #105696 (frontend counterpart so we don't fail serializer validation; deployed) followup: #105980 `on_command_phrase` is no longer being checked in Overwatch or in `issue_comment.py` when running code review. Let's remove it from `RepositorySettings` (migration) and from the `CodeReviewTrigger` enum. Note: I'm not going to manually add it to `overwatch_rpc.py` since Overwatch isn't checking this trigger anymore and is in the process of being migrated to Sentry.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to ENG-6194
depends on https://github.com/codecov/overwatch/pull/622
Since we are not charging by review, let's make sure the
on_command_phrasetrigger is always turned on and immutable inRepositorySettings. We remove it from the form options and update the help text to specify the command phrase.Before
After