fix(issue-search): correctly parse negated contains filters #105699
Merged
+30
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SENTRY-44YF
In some (very specific) queries, we fail to unpack issue search conditions correctly. More specifically, when we have a negation, plus a 'contains' filter, plus wildcards, we end up with one too many levels of nesting, leading to the error. We can unpack this condition to OR everything together and handle it correctly.
My understanding is that a more thorough solution is to migrate the issue search to use snql. I opted for this solution since it is considerably simpler, and I don't see an easy way to do this migration.
example:
!title:[*test*,*test2*]