fix(aci): use singular preferred detector in workflow processing round 2 #105865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
kcons
approved these changes
Jan 8, 2026
Member
kcons
left a comment
kcons
left a comment
There was a problem hiding this comment.
All optional notes or random asides, but I'd like to be sure we're not logging an exception every time we choose issue stream as primary.
| event_data: WorkflowEventData, detector: Detector | None = None | ||
| def get_detectors_for_event_data( | ||
| event_data: WorkflowEventData, | ||
| detector: Detector | None = None, |
Member
There was a problem hiding this comment.
idle thought: this should probably be known_preferred for clarity. But feel free to ignore this thought.
| mock_logger.info.assert_any_call( | ||
| "workflow_engine.process_workflows.evaluation.workflows.not_triggered", | ||
| extra={ | ||
| "event_id": self.event.event_id, |
Member
There was a problem hiding this comment.
I really wish there were a less awkward way to assert a small subset of possible keys so that any change to the logged extras doesn't break this test.
Well, abstractions for that do exist, they're just not idiomatic, so maybe I'll hack on that at some point.
Member
Author
There was a problem hiding this comment.
I'm familiar with using ANY but that's it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#105674 round 2 and tests the behavior that broke
This is safe to merge now that we don't have any non error, non metric issues going through workflow engine + the issue stream detector is currently disabled.