Skip to content

fix(logs): Show span_id in log detail view #110710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjq merged 1 commit into from
Mar 17, 2026
Merged

fix(logs): Show span_id in log detail view #110710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion static/app/views/explore/logs/constants.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ export const HiddenLogDetailFields: OurLogFieldKey[] = [
'sentry.timestamp_nanos',
'sentry.observed_timestamp_nanos',
'tags[sentry.trace_flags,number]',
'span_id',
];

export const DeprecatedLogDetailFields: OurLogFieldKey[] = [
Expand Down
6 changes: 3 additions & 3 deletions static/app/views/explore/logs/tables/logsTableRow.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,9 +266,6 @@ describe('logsTableRow', () => {
expect(screen.getByText('test log body')).toBeInTheDocument();
expect(screen.getByText('Apr 10, 2025 7:21:10.049 PM')).toBeInTheDocument(); // This is using precise timestamp on log fixture, which overrides passed regular timestamp.

// Check that the span ID is not rendered
expect(screen.queryByText('span_id')).not.toBeInTheDocument();

// Expand the row to show the attributes
const logTableRow = await screen.findByTestId('log-table-row');
expect(logTableRow).toBeInTheDocument();
Expand Down Expand Up @@ -320,6 +317,9 @@ describe('logsTableRow', () => {
})
);

// Check that the span ID is rendered in the expanded details
expect(screen.getByTestId('tree-key-span_id')).toBeInTheDocument();

// Check that the attribute values are rendered
expect(screen.queryByText(projects[0]!.id)).not.toBeInTheDocument();
expect(screen.getAllByText('info')).toHaveLength(2); // Severity circle and text
Expand Down
Loading