Conversation
Add conditional onboarding step array behind the onboarding-scm feature flag. When enabled, the flow shows 5 steps (Welcome, Connect Repository, Platform & Features, Project Details, Install SDK) instead of the legacy 3 steps. - Add SCM_CONNECT, SCM_PLATFORM_FEATURES, SCM_PROJECT_DETAILS step IDs - Create placeholder step components with heading and Continue button - Extend OnboardingContext with selectedIntegration, selectedRepositories, and selectedFeatures state backed by session storage - Pass onboardingSteps as parameter to useBackActions instead of importing - Fix goNextStep to allow platform from context for SCM flow - Replace fragile index-based step lookups with OnboardingStepId enum refs Refs VDY-18 Co-Authored-By: Claude Opus 4.6 <noreply@example.com>
github-actions
bot
added
the
Scope: Frontend
…dk test The OnboardingContext type now requires setSelectedIntegration, setSelectedRepositories, and setSelectedFeatures. Add these mock functions to satisfy the type checker. Co-Authored-By: Claude Opus 4.6 <noreply@example.com>
Verify the flag-gated SCM onboarding flow navigates correctly through all 5 steps: welcome -> scm-connect -> scm-platform-features -> scm-project-details -> setup-docs. Also covers back navigation, the setup-docs guard requiring a platform selection, and redirect of legacy step URLs to welcome when the SCM flag is on. Co-Authored-By: Claude Opus 4.6 <noreply@example.com>
…SCM flow Redirect deep-links with invalid platforms to the SCM_PLATFORM_FEATURES step when the SCM flag is on, instead of SELECT_PLATFORM which does not exist in the SCM step array. Preserve SCM context state (integration, repositories, features) when clearing the selected platform. Previously removeOnboarding() wiped the entire session storage key. Now only perform a full reset when no other SCM state remains. Co-Authored-By: Claude Opus 4.6 <noreply@example.com>
evanpurkhiser
approved these changes
Mar 16, 2026
jaydgoss
deleted the
jaygoss/vdy-18-add-feature-flag-and-scaffold-scm-onboarding-steps-with
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scaffold the frontend onboarding step array for the SCM-first onboarding flow behind the
organizations:onboarding-scmfeature flag. When enabled, the onboarding shows 5 steps instead of the legacy 3, with placeholder components for each new step that just render a heading and Continue button.The feature flag was registered in #110570. This PR adds the frontend wiring:
OnboardingStepIdenum values (SCM_CONNECT,SCM_PLATFORM_FEATURES,SCM_PROJECT_DETAILS)ScmConnect,ScmPlatformFeatures,ScmProjectDetails)OnboardingContextwithselectedIntegration,selectedRepositories, andselectedFeaturesstate (session storage backed)useBackActionsto acceptonboardingStepsas a parameter instead of importing the now-conditional module-level constantgoNextStepto allow navigation to SETUP_DOCS when platform is set via context (needed for the SCM flow where platform selection happens in an earlier step)onboardingSteps[2]) withOnboardingStepIdenum referencesWith the flag off, behavior is unchanged (existing tests all pass).
Refs VDY-18