fix(tests): Use explicit region override in snowflake ID tests#110774
Merged
mchen-sentry merged 2 commits intomasterfrom Mar 16, 2026
Merged
fix(tests): Use explicit region override in snowflake ID tests#110774mchen-sentry merged 2 commits intomasterfrom
mchen-sentry merged 2 commits intomasterfrom
Conversation
Two snowflake tests hardcode expected values assuming region_snowflake_id=0. Under xdist, workers use worker_num+1 instead, breaking the assertions. Wrap in override_regions with an explicit Cell so expected values are deterministic regardless of the test environment's default region config.
joshuarli
approved these changes
Mar 16, 2026
JonasBa
pushed a commit
that referenced
this pull request
Mar 16, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two snowflake tests (
test_generate_correct_ids,test_generate_correct_ids_with_region_sequence) hardcode expected snowflake values assumingregion_snowflake_id=0. Under xdist, workers useworker_num + 1instead, breaking the assertions.Fix: Wrap both tests in
override_regionswith an explicitCell("test-region", 0, ...)so the region's snowflake ID is deterministic regardless of the test environment's default region configuration.