ref: Convert from useRoutes() to useMatches() in areas related to getRouteStringFromRoutes()#112265
Open
ref: Convert from useRoutes() to useMatches() in areas related to getRouteStringFromRoutes()#112265
Conversation
github-actions
bot
added
the
Scope: Frontend
ryan953
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes almost all the
useRoutes()calls related togetRouteStringFromRoutes().There's still a few more related to breadcrumbs, and a class-based
<DateRange>component :(All the changes were very mechanical:
routesformatchesmost of the time.getRouteStringFromRouteshas a new parallel impl formatches, test was updated to match and i validated it in-app toouseRouteActivatedHook()accepts more props than it uses. I even added a new prop to the list, because react was complaining that the hook was not being called from within a Context parent. I guess our hooks system loses React Context links between the top of the tree and lower down. The specific type is vendored, so i left it alone.Related to https://github.com/getsentry/frontend-tsc/issues/78