ref(workflow_engine): Normalize the Workflow creation for a new project#112276
Draft
saponifi3d wants to merge 15 commits intomasterfrom
Draft
ref(workflow_engine): Normalize the Workflow creation for a new project#112276saponifi3d wants to merge 15 commits intomasterfrom
saponifi3d wants to merge 15 commits intomasterfrom
Conversation
9e8cb89 to
d1ae9bb
Compare
682bf2a to
2f3a48c
Compare
d1ae9bb to
f146ca8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
aa02f39 to
7659b1a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
created a `defaults/workflows.py` so we can separate the signal handlers and the default creation code.
…f the default values
1783511 to
d5af62d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
…nditions that might cause this to be invoked mulitple times
…ing it because it's not clear where its' eing used / how
Contributor
Backend Test FailuresFailures on
|
…g tests for now, start updating tests that are failing because of the logic change
Contributor
Backend Test FailuresFailures on
|
Contributor
Backend Test FailuresFailures on
|
f01c2e2 to
b292211
Compare
Contributor
Backend Test FailuresFailures on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate the
Workflow(/ Issue rule code) to match the patterns from the detectors PR and remove uses ofIssueAlertMigrator.This introduces a subtle change as well; before this would ensure connections for ErrorDetector + IssueStreamDetector to every workflow; now this will only use the IssueStreamDetector to reduce the redundant connections.
The remainder of the code is logically unchanged.