Skip to content

fix(textarea): Use correct prop for minRows in autosized textarea#112288

Merged
malwilley merged 1 commit intomasterfrom
malwilley/core-snapshot-audit
Apr 6, 2026
Merged

fix(textarea): Use correct prop for minRows in autosized textarea#112288
malwilley merged 1 commit intomasterfrom
malwilley/core-snapshot-audit

Conversation

@malwilley
Copy link
Copy Markdown
Member

react-textarea-autosize accepts minRows, not rows:

export interface TextareaAutosizeProps extends Omit<TextareaProps, 'style'> {
    maxRows?: number;
    minRows?: number;
    onHeightChange?: (height: number, meta: TextareaHeightChangeMeta) => void;
    cacheMeasurements?: boolean;
    style?: Style;
}

I'm noticing that TextArea doesn't have a story file?

Also, I tried adding snapshot tests for this component but I couldn't get the snapshots to render the autosizing correctly. I may be missing something, or this could be a gap with the snapshotting framework (cc @rbro112)

@malwilley malwilley requested a review from a team as a code owner April 6, 2026 20:44
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 6, 2026
@malwilley malwilley merged commit 8a83ad6 into master Apr 6, 2026
75 checks passed
@malwilley malwilley deleted the malwilley/core-snapshot-audit branch April 6, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants