feat: Restrict datacarriersize to 0, 42, or 83 bytes #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gh057-ai
commented
Oct 18, 2025
gh057-ai
commented
- Add custom Zod validation to only allow 0, 42, or 83 bytes
- Link datacarriersize to datacarrier toggle (auto-set to 0 when disabled)
- Add disabledWhen support to NumberOption interface
- Update UI descriptions to reflect restrictions
- Add custom Zod validation to only allow 0, 42, or 83 bytes - Link datacarriersize to datacarrier toggle (auto-set to 0 when disabled) - Add disabledWhen support to NumberOption interface - Update UI descriptions to reflect restrictions
|
What is the rationale for limiting user-specified settings? If anything, it seems like Umbrel should be allowing more choices for users, not less. |
Author
This should help reduce spam caused by core version 30 with a user activated soft fork |
|
NACK |
Author
|
sorry you have luke dash-jr syndrome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.