Add Trezor Suite connection details

[sime]

The recent release of Trezor Suite include Electrum server support..

[louneskmt]

Hey @sime @marekrjpolak, thanks for the PR!

As Trezor Suite seems to use an external Tor proxy (default 127.0.0.1:9050), we need to make sure the user has a Tor instance running on their computer. All the necessary code should be in my review comments.

[louneskmt]

And these are just some minor style changes to keep consistency with the other Connect Wallet instructions.

[louneskmt]

Btw, it looks like the use of a custom Electrum server is not available for testnet (I wanted to review this PR on my testnet instance). It really isn't a big deal, just wondering why, as it is basically the same thing than for mainnet.

[tsusanka]

Btw, it looks like the use of a custom Electrum server is not available for testnet (I wanted to review this PR on my testnet instance). It really isn't a big deal, just wondering why, as it is basically the same thing than for mainnet.

It was more of an oversight. Definitely smth we want: trezor/trezor-suite#5005.

[sime]

@louneskmt Thanks for the thorough review.

Though, I was a little trigger-happy with the TOR suggestions. Enabling TOR on Trezor Suite is simply a toggle, no need to instal anything else. Are you sure we need the TOR modal?

[louneskmt]

You mean there is a Tor instance built in Trezor Suite?

[sime]

@louneskmt Yes exactly.

[louneskmt]

Oh okay, so Trezor Suite starts its own Tor instance and uses it, unless the user specify a custom proxy address?

If so, I misunderstood the configuration. I thought it was trying to connect by default to an existing instance on 127.0.0.1:9050 ("You can configure the address to point to a different Tor instance. Default: 127.0.0.1:9050.").

[louneskmt]

That's great then, good job guys! My mistake, you can revert the commits related to the Tor modal and Tor first step.

[louneskmt]

Looks like it doesn't connect, while it is working in Sparrow. I've tried with both running my usual Tor instance and stopping it to let Trezor Suite run it.

[sime]

@louneskmt I pushed changes which removed the TOR setup steps.

Regarding you connecting from suite: Could you try again, please? I just tested Trezor Suite with Umbrel 0.4.17. It didn't work initially, but it eventually connected.

[sime]

You might be experiencing this bug: trezor/trezor-suite#5140

[louneskmt]

Maybe it comes from the fact that I don't have a Trezor configured with Suite?

[louneskmt]

You might be experiencing this bug: trezor/trezor-suite#5140

There should definitely be a "Test connection" button (like on Sparrow), or something like that.

[sime]

@louneskmt Yes, it's currently not possible to 'test' the connection without a Trezor connected.

[louneskmt]

Aaah that's why. I guess I just gonna approve this then, the PR looks good 👌

[louneskmt]

That should be good to merge @mayankchhabra @lukechilds 👌

[tsusanka]

Ping. Could we get this released? :)