server : run child server on localhost #17878
Closed
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
approved these changes
Dec 9, 2025
ngxson
reviewed
Dec 9, 2025
| } | ||
|
|
||
| // set model args | ||
| add_or_replace_arg(child_args, "--host", inst.meta.hostname); |
Collaborator
There was a problem hiding this comment.
If we know the host is always 127.0.0.1, I think it's easier to just hard code it here:
Suggested change
| add_or_replace_arg(child_args, "--host", inst.meta.hostname); | |
| add_or_replace_arg(child_args, "--host", "127.0.0.1"); |
So that the change will be migrated easier on #17859
Collaborator
aldehir
commented
Dec 9, 2025
Comment on lines
-574
to
+578
| base_params.hostname, | ||
| meta->hostname, |
Collaborator
Author
There was a problem hiding this comment.
@ngxson I believe this is still an issue. The router tries to proxy to 0.0.0.0:{child-port} and does not work, at least on windows.
I haven't had the time to update the PR to hardcode it, but I can later or you can apply it in the other PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing in
--host 0.0.0.0, the child runs on host0.0.0.0and the router tries to access it at0.0.0.0. I can't think of why the child should not always run on127.0.0.1.get_free_port()binds toINADDR_ANY, which should select a port that is available across all interfaces. This can be changed toINADDR_LOOPBACKif we ensure the child will only ever bind to127.0.0.1. If not, thenINADDR_ANYis a safe choice.fixes #17862