CUDA: fix unpadded strides in MMA FA kernel #17891
Open
+32
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17796 .
The problem is that for determining whether the kernel can assume aligned and padded allocations the code on master is only considering the tensor shapes, but not the tensor strides. So with the bandwidth-optimal copy sizes of 4/16 bytes you can end up with misaligned pointers.
Performance changes
For most models the performance should remain unchanged since they use GQA and this PR only affects models without GQA or if insufficient padding is used. I'm not sure what is happening with the V100 performance at medium batch sizes - I didn't yet really optimize this kernel for that particular GPU so I'm wondering whether the new loop structure results in different register usage.