whisper : add submodule for ggml #3001
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the ggml source tree in favor of creating a git submodule for https://github.com/ggml-org/ggml instead. Refs: ggml-org#2785
This commit adds a recipe/target to the makefile to update the ggml submodule. The motivation for this is that it is not always clear how to update and what if any flags are needed to update the submodule.
This commit updates the `git ls-files` command in the Ruby bindings to include submodules. The motivation for this change is that without it the rake command will fail as all needed file will not be copied.
|
Heads up, I am having some second thoughts about using git submodules vs a mono repo. It's good to have this as a demonstration, but likely won't be merged soon - at least before we make the final decision how to organize the projects. Some related discussion in ggml-org/ggml#1130 for context. |
|
Closing this as we an always reopen later if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces the ggml sources with a git submodule.
The individual commits are the steps I took to do this. Hopefully they are readable on their own but if not let me know and I'll as a better description here.
One thing I did add which might not be obvious is a make recipe/target to update the ggml submodule:
$ make update-ggmlThis is mainly because I tend to forget the options for this.
Refs: #2785
(This does not resolve #2785 because I was not sure about
Add support for linking against external ggml binaries).