Skip to content

fix: Notify build_runner of dependency on inputSpec #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PvtPuddles
Copy link

Description

When the builder loads the inputSpec, I have added a quick call to buildStep.canRead. This notifies build_runner that the generator depends on the inputSpec file, causing the runner to be called whenever the spec changes.

Notes:

  • I did not remove the existing work-around; this fix only works when the API Spec lives inside the lib directory (and this would be a breaking change).
  • I have not updated documentation; I will wait for the green light on the code change first.

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants