Wrap EOF with helpful message for empty JSON request body#4496
Open
sh9336 wants to merge 2 commits intogin-gonic:masterfrom
Open
Wrap EOF with helpful message for empty JSON request body#4496sh9336 wants to merge 2 commits intogin-gonic:masterfrom
sh9336 wants to merge 2 commits intogin-gonic:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4496 +/- ##
==========================================
- Coverage 99.21% 99.06% -0.16%
==========================================
Files 42 44 +2
Lines 3182 2990 -192
==========================================
- Hits 3157 2962 -195
- Misses 17 19 +2
- Partials 8 9 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the error returned by ShouldBindJSON when the request
body is empty.
Previously, decoding an empty JSON body returned a plain io.EOF error.
This change wraps io.EOF with a clearer message ("empty request body")
while preserving the original error, so errors.Is(err, io.EOF) continues
to work.
An external test has been added to document and verify this behavior.
Happy to adjust the wording or approach if maintainers prefer.