feat(test): add RunTestHandler to flush status in test contexts#4570
Open
abhiyankhanal wants to merge 2 commits intogin-gonic:masterfrom
Open
feat(test): add RunTestHandler to flush status in test contexts#4570abhiyankhanal wants to merge 2 commits intogin-gonic:masterfrom
abhiyankhanal wants to merge 2 commits intogin-gonic:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4570 +/- ##
==========================================
- Coverage 99.21% 98.31% -0.90%
==========================================
Files 42 48 +6
Lines 3182 3148 -34
==========================================
- Hits 3157 3095 -62
- Misses 17 44 +27
- Partials 8 9 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
When using CreateTestContext directly to test handlers, ctx.Status() sets the status internally but it is not flushed to the underlying httptest.ResponseRecorder. RunTestHandler creates a test context, runs the handler chain, and calls WriteHeaderNow() so that the status code is properly reflected in the ResponseWriter. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace string literals with http.Method* constants to satisfy the usestdlibvars linter. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
29918cd to
3f607b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RunTestHandler(w, req, handlers...)helper function totest_helpers.goctx.Status()doesn't flush the status code tohttptest.ResponseRecorder.Codewhen usingCreateTestContextdirectlyCreateTestContextbehavior is unchanged (backward compatible)Related Issue
Closes #3443
Changes Made
test_helpers.go: AddedRunTestHandlerfunction that creates a test context, runs handlers, and callsWriteHeaderNow()to flush the statustest_helpers_test.go: Added 5 test cases covering status flushing, middleware chains, default status, request setting, and backward compatibilityTesting
go test -run "TestRunTestHandler|TestCreateTestContextBackward" -v -count=1— all tests passExample Usage
🤖 Generated with Claude Code