Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pp 810 add document id to super properties #675

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

abolfazlimahdi
Copy link
Contributor

No description provided.

@abolfazlimahdi abolfazlimahdi self-assigned this Feb 18, 2025
@@ -2,6 +2,7 @@ package net.gini.android.capture.network

import android.content.Context
import android.text.TextUtils
import android.util.Log
import androidx.annotation.VisibleForTesting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this line is added by mistake?

Copy link
Contributor

@obaidgini obaidgini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mahdiabolfazli Everything looks good, I think 1 import is added by mistake.
Thank you :)

@obaidgini obaidgini self-requested a review February 18, 2025 17:06
Copy link
Contributor

@obaidgini obaidgini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thank you 👌

@abolfazlimahdi abolfazlimahdi added the Waiting for QA Pr's which were raised, but not picked by QA yet. After testing it will be merged. label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting for QA Pr's which were raised, but not picked by QA yet. After testing it will be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants