Added new 'add_border' arg for adding outline to line-shapes & corrected color mapping logic#58
Open
erstearns wants to merge 11 commits intogiocomai:masterfrom
Open
Added new 'add_border' arg for adding outline to line-shapes & corrected color mapping logic#58erstearns wants to merge 11 commits intogiocomai:masterfrom
erstearns wants to merge 11 commits intogiocomai:masterfrom
Conversation
…e arg and set palette to correct number of unique vals and changed names to match unique vals of colour_by arg
…g is doing and also added order_by arg to function and testing as i go
… and coded up the inclusion of a legend
Color mapping & legend & ordering
Color mapping & order & legend
…hape 1 width unit larger than the original line
added new arg to allow user to add borders to lines by creating new s…
Adding new arg 'add_border' to allow user to add border around each line
…f unique wp- corrected
found error in code to check number of colors in pal against number o…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New boolean arg: 'add_border' allows user to add a gray border around each line. This is very helpful if you have a palette with light colors as it makes them pop a bit more against the background and thus easier to see. In reality, this is another ggplot2 segment layer with a width of 1 + size_activity and colored gray. Future improvements could include the addition of args for setting this 'outline' layer width and color.
Also found and corrected an error early in the function that checks whether the user has the same number of colors in their palette as they do unique values of 'wp'. The error did not affect functionality, just message back to the user was note correct.