Support URLs in forge pr checkout#104
Merged
Merged
Conversation
andrew
requested changes
May 26, 2026
andrew
left a comment
andrew
left a comment
Contributor
There was a problem hiding this comment.
Thanks, this covers all three URL forms from #102 (url.Parse strips the fragment, and len(parts) >= 4 tolerates /pull/123/files). A few things below before merging.
On the architecture: agree that per-forge parsing is the right call given GitLab's /-/ and subgroups. The four parsePath bodies being near-copies is fine, but the 5-value return (7 from ResourceFromURL) is going to hurt the next time someone adds discussions or releases. A small ResourceRef struct would also give "pr" / "issue" somewhere to live as constants rather than magic strings repeated across four packages. Not blocking on it, but worth considering while this is fresh.
andrew
approved these changes
May 26, 2026
Contributor
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #102
forge has some helper functions that parse repo/owner from a URL, all within
detect.goandforge.go. For examplesplitOwnerRepojust handles all URLs with zero levels of abstraction.But I think this is the right architecture instead: Parse domain out of URL, and dispatch to the respective forge module. The cost is quite a bit of code duplication, but the logic can be tested separately.